You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/02/16 19:13:28 UTC
[jira] Created: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Add configuration setting to cap the number of Thrift connections
-----------------------------------------------------------------
Key: CASSANDRA-2176
URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
Project: Cassandra
Issue Type: Bug
Components: API
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.7.3
At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-2176:
--------------------------------------
Attachment: (was: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt)
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995476#comment-12995476 ]
Jonathan Ellis commented on CASSANDRA-2176:
-------------------------------------------
Probably. I think what we want is for clients to get an immediate refusal rather than a timeout, and a warning but no tracebacks in the Cassandra log.
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998607#comment-12998607 ]
Jonathan Ellis commented on CASSANDRA-2176:
-------------------------------------------
Jake, can you attach a version w/ only the substantive changes to CustomTPS so I can tell what changed?
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-2176:
--------------------------------------
Attachment: (was: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt)
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2176:
--------------------------------------
Attachment: (was: 2176-v2.txt)
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt, 2176-v2.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2176:
--------------------------------------
Attachment: 2176-v2.txt
v2 implements option 2 and adds an explanation to cassandra.yaml
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt, 2176-v2.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998679#comment-12998679 ]
T Jake Luciani commented on CASSANDRA-2176:
-------------------------------------------
k, changes attached
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995447#comment-12995447 ]
T Jake Luciani commented on CASSANDRA-2176:
-------------------------------------------
If we just capped the thread pool it should be effectively the same correct?
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-2176:
--------------------------------------
Attachment: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt, 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-2176:
--------------------------------------
Attachment: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-2176:
--------------------------------------
Attachment: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-2176.
---------------------------------------
Resolution: Fixed
committed
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt, 2176-v2.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999471#comment-12999471 ]
Jonathan Ellis commented on CASSANDRA-2176:
-------------------------------------------
If we could return an exception then we would make a separate exception class for it. But we can't, because Thrift RPC isn't designed to allow returning anything (an exception is just a special return value over the socket) except in response to a method call.
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2176:
--------------------------------------
Remaining Estimate: 4h
Original Estimate: 4h
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998649#comment-12998649 ]
T Jake Luciani commented on CASSANDRA-2176:
-------------------------------------------
bq. What's going on w/ the diff to CustomTPS, is that your IDE going crazy w/ whitespace changes?
The current file is totally unformatted. The core of the changes is in the serve() where it makes sure activeClient counts is <= max. The activeClients is decremented when a client hangs up see WorkerProcess.run
bq. is there any reason not to make these cassandra.conf options instead of -D flags?
No, I just figures most people don't care, would you like me to add this there?
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2176:
--------------------------------------
Attachment: 2176-v2.txt
oops, didn't remove the original post-accept check there. better v2 attached.
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt, 2176-v2.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002700#comment-13002700 ]
Hudson commented on CASSANDRA-2176:
-----------------------------------
Integrated in Cassandra-0.7 #348 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/348/])
add rpc_[min|max]_threads
patch by tjake and jbellis for CASSANDRA-2176
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt, 2176-v2.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002042#comment-13002042 ]
T Jake Luciani commented on CASSANDRA-2176:
-------------------------------------------
LGTM +1
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.4
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt, 2176-v2.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996538#comment-12996538 ]
T Jake Luciani commented on CASSANDRA-2176:
-------------------------------------------
This patch lets the user specify on startup bin/cassandra -Dmin.rpc.threads and -Dmax.rpc.threads
If max clients are connected then new users get kicked.
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2176:
--------------------------------------
Reviewer: jbellis
Assignee: T Jake Luciani (was: Jonathan Ellis)
Issue Type: Improvement (was: Bug)
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998657#comment-12998657 ]
Jonathan Ellis commented on CASSANDRA-2176:
-------------------------------------------
bq. The current file is totally unformatted
Committed a reformat so we don't have to mix them together.
bq. would you like me to add this there?
Yes, let's do that.
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999451#comment-12999451 ]
Jonathan Ellis commented on CASSANDRA-2176:
-------------------------------------------
There's three options for capping the number of connections:
- close the listening socket
- leave the socket open but stop accept()ing connections
- accept new connections, send an error message, then close them
The third option is generally seen as "best" (some discussion: http://fixunix.com/unix/379049-server-socket-how-limit-number-connections.html) but Thrift doesn't give us a way to send an error w/o first processing a request. So I'm wondering if we should go with option 2 instead -- "timed out trying to connect" seems more straightforward than option 1 (indistinguishable from cassandra not running) or option 3 (which makes it easy to do the wrong thing on the client side -- i.e. a naive client may immediately try to reconnect).
Thoughts?
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Nate McCall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999466#comment-12999466 ]
Nate McCall commented on CASSANDRA-2176:
----------------------------------------
I think I would prefer to get a TimeoutException back as this falls into the general category of "that node is pretty busy right now" and I would take the same avoidance strategy as with other TimeoutException cases.
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-2176:
--------------------------------------
Attachment: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996541#comment-12996541 ]
Jonathan Ellis commented on CASSANDRA-2176:
-------------------------------------------
Is there any reason not to make these cassandra.conf options instead of -D flags?
What's going on w/ the diff to CustomTPS, is that your IDE going crazy w/ whitespace changes?
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2176) Add configuration setting to cap
the number of Thrift connections
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-2176:
--------------------------------------
Attachment: (was: 0001-CASSANDRA-2176-limit-number-of-connected-clients.txt)
> Add configuration setting to cap the number of Thrift connections
> -----------------------------------------------------------------
>
> Key: CASSANDRA-2176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2176
> Project: Cassandra
> Issue Type: Improvement
> Components: API
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Priority: Minor
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2176-limit-connected-clients-and-config.txt
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> At least until CASSANDRA-1405 is done, it's useful to have a connection cap to prevent misbehaving clients from DOSing the server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira