You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/05/08 22:44:13 UTC
Re: Review Request 33513: Added a modules-aware factory for
allocators.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33513/
-----------------------------------------------------------
(Updated May 8, 2015, 8:44 p.m.)
Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Merged with the previous patch; updated comments.
Bugs: MESOS-2597
https://issues.apache.org/jira/browse/MESOS-2597
Repository: mesos
Description
-------
With the support of allocator modules, it should be possible to select and instantiate an allocator based on its name.
Diffs (updated)
-----
include/mesos/master/allocator.hpp e821bf33536ab70cc2be45b9239c089e251f1f24
src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
src/master/allocator/allocator.cpp PRE-CREATION
src/master/allocator/mesos/allocator.hpp 2681af5ff265b84c5174de3ad459292e006dcf97
src/master/allocator/mesos/hierarchical.hpp 09adced9d8712b3eeda885d598443791186890db
src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
Diff: https://reviews.apache.org/r/33513/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 33513: Added a modules-aware factory for
allocators.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On May 11, 2015, 6:26 p.m., Niklas Nielsen wrote:
> > src/master/allocator/allocator.cpp, line 39
> > <https://reviews.apache.org/r/33513/diff/6/?file=954174#file954174line39>
> >
> > Unused variable? Did you want to return this somewhere?
>
> Niklas Nielsen wrote:
> Ping - let's get this committed :)
My bad: dangling code from the previous revision. Thanks for catching this!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33513/#review83258
-----------------------------------------------------------
On May 8, 2015, 11:47 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33513/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 11:47 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the support of allocator modules, it should be possible to select and instantiate an allocator based on its name.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp e821bf33536ab70cc2be45b9239c089e251f1f24
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/master/allocator/allocator.cpp PRE-CREATION
> src/master/allocator/mesos/allocator.hpp 2681af5ff265b84c5174de3ad459292e006dcf97
> src/master/allocator/mesos/hierarchical.hpp 09adced9d8712b3eeda885d598443791186890db
> src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
> src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33513/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 33513: Added a modules-aware factory for
allocators.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On May 11, 2015, 11:26 a.m., Niklas Nielsen wrote:
> > src/master/allocator/allocator.cpp, line 39
> > <https://reviews.apache.org/r/33513/diff/6/?file=954174#file954174line39>
> >
> > Unused variable? Did you want to return this somewhere?
Ping - let's get this committed :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33513/#review83258
-----------------------------------------------------------
On May 8, 2015, 4:47 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33513/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 4:47 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the support of allocator modules, it should be possible to select and instantiate an allocator based on its name.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp e821bf33536ab70cc2be45b9239c089e251f1f24
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/master/allocator/allocator.cpp PRE-CREATION
> src/master/allocator/mesos/allocator.hpp 2681af5ff265b84c5174de3ad459292e006dcf97
> src/master/allocator/mesos/hierarchical.hpp 09adced9d8712b3eeda885d598443791186890db
> src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
> src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33513/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 33513: Added a modules-aware factory for
allocators.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33513/#review83258
-----------------------------------------------------------
src/master/allocator/allocator.cpp
<https://reviews.apache.org/r/33513/#comment134162>
Unused variable? Did you want to return this somewhere?
- Niklas Nielsen
On May 8, 2015, 4:47 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33513/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 4:47 p.m.)
>
>
> Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-2597
> https://issues.apache.org/jira/browse/MESOS-2597
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the support of allocator modules, it should be possible to select and instantiate an allocator based on its name.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp e821bf33536ab70cc2be45b9239c089e251f1f24
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/master/allocator/allocator.cpp PRE-CREATION
> src/master/allocator/mesos/allocator.hpp 2681af5ff265b84c5174de3ad459292e006dcf97
> src/master/allocator/mesos/hierarchical.hpp 09adced9d8712b3eeda885d598443791186890db
> src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
> src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
>
> Diff: https://reviews.apache.org/r/33513/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.5, CentOS 7.0)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 33513: Added a modules-aware factory for
allocators.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33513/
-----------------------------------------------------------
(Updated May 14, 2015, 1:22 p.m.)
Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Addressed comments.
Bugs: MESOS-2597
https://issues.apache.org/jira/browse/MESOS-2597
Repository: mesos
Description
-------
With the support of allocator modules, it should be possible to select and instantiate an allocator based on its name.
Diffs (updated)
-----
include/mesos/master/allocator.hpp e821bf33536ab70cc2be45b9239c089e251f1f24
src/Makefile.am 58ebe1af33257a5f72f6fbbab5dc1aaa979f4808
src/master/allocator/allocator.cpp PRE-CREATION
src/master/allocator/mesos/allocator.hpp 2681af5ff265b84c5174de3ad459292e006dcf97
src/master/allocator/mesos/hierarchical.hpp c22f04465f9cfb97dd3a53a77588ead1b3337fc4
src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
Diff: https://reviews.apache.org/r/33513/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
Re: Review Request 33513: Added a modules-aware factory for
allocators.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33513/
-----------------------------------------------------------
(Updated May 8, 2015, 11:47 p.m.)
Review request for mesos, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
Changes
-------
Updated the comment.
Bugs: MESOS-2597
https://issues.apache.org/jira/browse/MESOS-2597
Repository: mesos
Description
-------
With the support of allocator modules, it should be possible to select and instantiate an allocator based on its name.
Diffs (updated)
-----
include/mesos/master/allocator.hpp e821bf33536ab70cc2be45b9239c089e251f1f24
src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
src/master/allocator/allocator.cpp PRE-CREATION
src/master/allocator/mesos/allocator.hpp 2681af5ff265b84c5174de3ad459292e006dcf97
src/master/allocator/mesos/hierarchical.hpp 09adced9d8712b3eeda885d598443791186890db
src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c
src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3
src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
Diff: https://reviews.apache.org/r/33513/diff/
Testing
-------
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov