You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 14:17:20 UTC

[GitHub] [airflow] kaxil commented on a diff in pull request #28829: Make allowed_deserialization_classes more intuitive

kaxil commented on code in PR #28829:
URL: https://github.com/apache/airflow/pull/28829#discussion_r1065837802


##########
tests/serialization/test_serde.py:
##########
@@ -32,7 +32,7 @@
     VERSION,
     _compile_patterns,
     deserialize,
-    serialize,
+    serialize, _match,

Review Comment:
   Static checks are failing for this:
   
   ```diff
   diff --git a/tests/serialization/test_serde.py b/tests/serialization/test_serde.py
   index 88b012d..475525c 100644
   --- a/tests/serialization/test_serde.py
   +++ b/tests/serialization/test_serde.py
   @@ -31,8 +31,9 @@ from airflow.serialization.serde import (
        SCHEMA_ID,
        VERSION,
        _compile_patterns,
   +    _match,
        deserialize,
   -    serialize, _match,
   +    serialize,
    )
    from airflow.utils.module_loading import qualname
    from tests.test_utils.config import conf_vars
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org