You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/24 11:08:21 UTC

[GitHub] [spark] LuciferYang opened a new pull request #29864: [SPARK-32972][MESOS] Pass all `mllib` module UTs in Scala 2.13

LuciferYang opened a new pull request #29864:
URL: https://github.com/apache/spark/pull/29864


   ### What changes were proposed in this pull request?
   The main change of this pr is add a manual sort to `defaultConf ++ driverConf` before constructing `--conf` options to 
   ensure options has same order in Scala 2.12 and Scala 2.13.
   
   
   ### Why are the changes needed?
   We need to support a Scala 2.13 build.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   - Scala 2.12: Pass the Jenkins or GitHub Action
   
   - Scala 2.13: Pass GitHub 2.13 Build Action
   
   Do the following:
   
   ```
   dev/change-scala-version.sh 2.13
   mvn clean install -DskipTests  -pl resource-managers/mesos -Pscala-2.13 -Pmesos -am
   mvn test -pl resource-managers/mesos -Pscala-2.13 -Pmesos
   ```
   
   **Before**
   ```
   Tests: succeeded 106, failed 1, canceled 0, ignored 0, pending 0
   *** 1 TESTS FAILED ***
   ```
   
   **After**
   
   ```
   Tests: succeeded 107, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang removed a comment on pull request #29864: [SPARK-32987][MESOS] Pass all `mllib` module UTs in Scala 2.13

Posted by GitBox <gi...@apache.org>.
LuciferYang removed a comment on pull request #29864:
URL: https://github.com/apache/spark/pull/29864#issuecomment-698276483


   cc @srowen @dongjoon-hyun to review this patch ~ thx 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang closed pull request #29864: [SPARK-32987][MESOS] Pass all `mllib` module UTs in Scala 2.13

Posted by GitBox <gi...@apache.org>.
LuciferYang closed pull request #29864:
URL: https://github.com/apache/spark/pull/29864


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang closed pull request #29864: [SPARK-32987][MESOS] Pass all `mllib` module UTs in Scala 2.13

Posted by GitBox <gi...@apache.org>.
LuciferYang closed pull request #29864:
URL: https://github.com/apache/spark/pull/29864


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #29864: [SPARK-32972][MESOS] Pass all `mllib` module UTs in Scala 2.13

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29864:
URL: https://github.com/apache/spark/pull/29864#issuecomment-698276483


   cc @srowen @dongjoon-hyun to review this patch ~ thx 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #29864: [SPARK-32972][MESOS] Pass all `mllib` module UTs in Scala 2.13

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29864:
URL: https://github.com/apache/spark/pull/29864#issuecomment-698276483


   cc @srowen @dongjoon-hyun to review this patch ~ thx 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang removed a comment on pull request #29864: [SPARK-32987][MESOS] Pass all `mllib` module UTs in Scala 2.13

Posted by GitBox <gi...@apache.org>.
LuciferYang removed a comment on pull request #29864:
URL: https://github.com/apache/spark/pull/29864#issuecomment-698276483


   cc @srowen @dongjoon-hyun to review this patch ~ thx 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org