You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/08/22 11:42:51 UTC
[PR] fix(cli): declare the transcript command's mid-turn disposition [maka]
Astro-Han opened a new pull request, #3486:
URL: https://github.com/apache/maka/pull/3486
`main` is red: `test` fails at the Build step.
```
src/pi-tui-runner.ts(2877,5): error TS2741:
Property 'midTurn' is missing in type '{ description; run }'
but required in type 'Omit<MakaSlashCommand, "aliases"|"name">'
src/pi-tui-runner.ts(3015,9): error TS2322: ... not assignable to type 'MakaSlashCommand[]'
```
#2999 added `/transcript`; the change that made `midTurn` required on `MakaSlashCommand` landed separately. Each was green on its own branch — the break only exists where they meet, and the intermediate `main` runs were all cancelled by the next push, so no complete run reported it until now.
### Why `'local'` and not `'refuse'`
`'refuse'` is documented as the safe default for anything that mutates session state or opens a picker the turn would race. `/transcript` does neither: `showTranscriptViewer` (`pi-tui-runner.ts:2184`) only calls `tui.showOverlay` with a read-only viewer over the in-memory transcript. It never enters `runControl`, which is precisely the `'local'` contract.
It also matters for behaviour: mid-turn is when scrolling back through the transcript is *most* useful, and the viewer was built to be open while a turn runs. `'refuse'` would compile, but it would remove the command's main value.
### Verification
- `packages/cli` typechecks clean after rebuilding `@maka/core`.
- `apps/desktop` typechecks clean — 0 errors. Worth stating because a report suggested `ToastDiagnosticTarget` was a second break in `main`; it isn't. That type is a discriminated union where `{ sessionId }` alone is a valid member, and the desktop build only looked broken because the CLI build failed before reaching it.
---
*AI-assisted fix.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(cli): declare the transcript command's mid-turn disposition [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #3486:
URL: https://github.com/apache/maka/pull/3486#issuecomment-5380192135
Superseded by #3459, which landed `midTurn: 'local'` on `main` in b434a491 while this was open. `main` builds again, so this is redundant — closing.
For the record, `'local'` is the value that matches the handler: `showTranscriptViewer` only calls `tui.showOverlay` and never enters `runControl`, so the viewer stays usable mid-turn, which is when looking back is most useful. Sorry for the duplicate — I filed this without first checking whether a fix was already in flight.
Review assisted by AI (Claude Opus 5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(cli): declare the transcript command's mid-turn disposition [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed pull request #3486: fix(cli): declare the transcript command's mid-turn disposition
URL: https://github.com/apache/maka/pull/3486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org