You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by caty <gi...@git.apache.org> on 2016/05/17 08:15:23 UTC
[GitHub] thrift pull request: Fix buf for php close socket
GitHub user caty opened a pull request:
https://github.com/apache/thrift/pull/1011
Fix buf for php close socket
php must close the socket, anyhow.
otherwise you will get previous reponse when the previous request timeout and the socket is reused.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caty/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1011.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1011
----
commit 674dbbbe568d9fead9e218d27cd59c56544f4cde
Author: Huang yuzhen <ca...@users.noreply.github.com>
Date: 2016-05-17T08:12:06Z
Update TSocket.php
PHP must close the socket, anyhow.
otherwise you will get previous reponse when the previous request timeout and the socket is reused.
commit 8ac2ac9906f5e44da7c934187ac530427b300eb3
Author: Huang yuzhen <ca...@users.noreply.github.com>
Date: 2016-05-17T08:12:58Z
Merge pull request #1 from caty/caty-patch-php-close-socket
Update TSocket.php
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1011: Fix bug for php close socket
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1011
Superceded by #1233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1011: Fix bug for php close socket
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1011
I opened THRIFT-4154 and I am going to submit a second PR for this. If it passes CI builds I can merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1011: Fix bug for php close socket
Posted by caty <gi...@git.apache.org>.
Github user caty commented on the issue:
https://github.com/apache/thrift/pull/1011
I only change php code, why the Travis CI build failed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1011: Fix bug for php close socket
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1011
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1011: Fix bug for php close socket
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1011
@caty please open an Apache Thrift Jira ticket for this issue and rebase the pull request against master so we get a clean CI build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---