You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "liuzqt (via GitHub)" <gi...@apache.org> on 2025/07/26 02:50:00 UTC
[PR] [SPARK-52960][SQL] Show subtree string in LogicalQueryStage toString [spark]
liuzqt opened a new pull request, #51674:
URL: https://github.com/apache/spark/pull/51674
### What changes were proposed in this pull request?
Show subtree string in LogicalQueryStage toString
### Why are the changes needed?
Better debugging.
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
N/A
### Was this patch authored or co-authored using generative AI tooling?
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52960][SQL] Show subtree string in LogicalQueryStage toString [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #51674:
URL: https://github.com/apache/spark/pull/51674#issuecomment-3131138010
the pyspark failure is unrelated, thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52960][SQL] Show subtree string in LogicalQueryStage toString [spark]
Posted by "liuzqt (via GitHub)" <gi...@apache.org>.
liuzqt commented on PR #51674:
URL: https://github.com/apache/spark/pull/51674#issuecomment-3125153901
@maryannxue @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52960][SQL] Show subtree string in LogicalQueryStage toString [spark]
Posted by "liuzqt (via GitHub)" <gi...@apache.org>.
liuzqt commented on code in PR #51674:
URL: https://github.com/apache/spark/pull/51674#discussion_r2237445181
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/LogicalQueryStage.scala:
##########
@@ -82,4 +82,32 @@ case class LogicalQueryStage(
case _: QueryStageExec => true
case _ => false
}
+
+ override def generateTreeString(
+ depth: Int,
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52960][SQL] Show subtree string in LogicalQueryStage toString [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #51674: [SPARK-52960][SQL] Show subtree string in LogicalQueryStage toString
URL: https://github.com/apache/spark/pull/51674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52960][SQL] Show subtree string in LogicalQueryStage toString [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #51674:
URL: https://github.com/apache/spark/pull/51674#discussion_r2236342660
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/LogicalQueryStage.scala:
##########
@@ -82,4 +82,32 @@ case class LogicalQueryStage(
case _: QueryStageExec => true
case _ => false
}
+
+ override def generateTreeString(
+ depth: Int,
Review Comment:
nit: 4 spaces indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org