You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by MartinWeindel <gi...@git.apache.org> on 2014/08/25 14:55:54 UTC

[GitHub] mesos pull request: Fix for MESOS-1688

GitHub user MartinWeindel opened a pull request:

    https://github.com/apache/mesos/pull/24

    Fix for MESOS-1688

    As already explained in [MESOS-1688](https://issues.apache.org/jira/browse/MESOS-1688), there are schedulers allocating memory only for the executor and not for tasks. For tasks only CPU resources are allocated in this case.
    Such a scheduler does not get offered any idle CPUs if the slave has nearly used up all memory.
    This can easily lead to a dead lock (in the application, not in Mesos).
    
    Simple example:
    1. Scheduler allocates all memory of a slave for an executor
    2. Scheduler launches a task for this executor (allocating 1 CPU)
    3. Task finishes: 1 CPU , 0 MB memory allocatable.
    4. No offers are made, as no memory is left. Scheduler will wait of offers forever. Dead lock in the application.
    
    To fix this problem, offers must be made if either CPU or memory is allocatable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MartinWeindel/mesos master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mesos/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 8d816e4582208802d319071e90ef4e1810960718
Author: Martin Weindel <ma...@gmail.com>
Date:   2014-08-25T12:30:51Z

    fix for MESOS-1688

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mesos pull request: Fix for MESOS-1688

Posted by MartinWeindel <gi...@git.apache.org>.

Github user MartinWeindel commented on the pull request:

    https://github.com/apache/mesos/pull/24#issuecomment-53337852
  
    post on reviewboard will follow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mesos pull request: Fix for MESOS-1688

Posted by tnachen <gi...@git.apache.org>.

Github user tnachen commented on the pull request:

    https://github.com/apache/mesos/pull/24#issuecomment-53287289
  
    hi @MartinWeindel, can you post on reviewboard instead? That's how all the mesos patches are reviewed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] mesos pull request: Fix for MESOS-1688

Posted by MartinWeindel <gi...@git.apache.org>.

Github user MartinWeindel closed the pull request at:

    https://github.com/apache/mesos/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---