You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/05/07 14:12:58 UTC
[kudu-CR] KUDU-2806: Deflake testForceIncrementalBackup
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13262
Change subject: KUDU-2806: Deflake testForceIncrementalBackup
......................................................................
KUDU-2806: Deflake testForceIncrementalBackup
This deflakes testForceIncrementalBackup by waiting
1 ms before setting the beforeMs. This is important
because backup times are at ms granuarity even though
snapshot times are at microsecond/logic granularity.
Change-Id: Icaab7ff856e46860f6d4ee999b05afd783e01443
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/13262/1
--
To view, visit http://gerrit.cloudera.org:8080/13262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaab7ff856e46860f6d4ee999b05afd783e01443
Gerrit-Change-Number: 13262
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2806: Deflake testForceIncrementalBackup
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13262 )
Change subject: KUDU-2806: Deflake testForceIncrementalBackup
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaab7ff856e46860f6d4ee999b05afd783e01443
Gerrit-Change-Number: 13262
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 07 May 2019 14:35:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2806: Deflake testForceIncrementalBackup
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13262 )
Change subject: KUDU-2806: Deflake testForceIncrementalBackup
......................................................................
KUDU-2806: Deflake testForceIncrementalBackup
This deflakes testForceIncrementalBackup by waiting
1 ms before setting the beforeMs. This is important
because backup times are at ms granuarity even though
snapshot times are at microsecond/logic granularity.
Change-Id: Icaab7ff856e46860f6d4ee999b05afd783e01443
Reviewed-on: http://gerrit.cloudera.org:8080/13262
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Grant Henke: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaab7ff856e46860f6d4ee999b05afd783e01443
Gerrit-Change-Number: 13262
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2806: Deflake testForceIncrementalBackup
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-2806: Deflake testForceIncrementalBackup
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Icaab7ff856e46860f6d4ee999b05afd783e01443
Gerrit-Change-Number: 13262
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2806: Deflake testForceIncrementalBackup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13262 )
Change subject: KUDU-2806: Deflake testForceIncrementalBackup
......................................................................
Patch Set 1: Code-Review+2
I tested out this change with dist-test. Before the change, testForceIncrementalBackup was 1-2% flaky (16/1000 failures). After this change, there were no failures in 1000 runs.
--
To view, visit http://gerrit.cloudera.org:8080/13262
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaab7ff856e46860f6d4ee999b05afd783e01443
Gerrit-Change-Number: 13262
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 07 May 2019 14:43:25 +0000
Gerrit-HasComments: No