You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/09/24 02:21:16 UTC
[commons-pool] branch master updated (b96bf81 -> 680b7f4)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git.
from b96bf81 Update optional asm-util from 8.0.1 to 9.0 #44.
new aca566e Use try-with-resource. Remove unused imports.
new 131642f Remove unused.
new 680b7f4 Remove unused imports.
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../pool2/MethodCallPoolableObjectFactory.java | 1 -
.../apache/commons/pool2/ObjectPoolIssue326.java | 2 -
.../org/apache/commons/pool2/TestObjectPool.java | 2 -
.../apache/commons/pool2/VisitTrackerFactory.java | 2 -
.../commons/pool2/impl/AtomicIntegerFactory.java | 1 -
.../pool2/impl/TestBaseGenericObjectPool.java | 45 +++++++++++-----------
.../commons/pool2/impl/TestEvictionTimer.java | 4 +-
.../pool2/impl/TestGenericKeyedObjectPool.java | 2 +-
8 files changed, 25 insertions(+), 34 deletions(-)
[commons-pool] 03/03: Remove unused imports.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit 680b7f4c5bf3540bf7dbf2c627be697dc7df18ea
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Sep 23 22:19:27 2020 -0400
Remove unused imports.
---
.../java/org/apache/commons/pool2/MethodCallPoolableObjectFactory.java | 1 -
src/test/java/org/apache/commons/pool2/ObjectPoolIssue326.java | 2 --
src/test/java/org/apache/commons/pool2/TestObjectPool.java | 2 --
src/test/java/org/apache/commons/pool2/VisitTrackerFactory.java | 2 --
4 files changed, 7 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/MethodCallPoolableObjectFactory.java b/src/test/java/org/apache/commons/pool2/MethodCallPoolableObjectFactory.java
index 7e1a39d..ce69321 100644
--- a/src/test/java/org/apache/commons/pool2/MethodCallPoolableObjectFactory.java
+++ b/src/test/java/org/apache/commons/pool2/MethodCallPoolableObjectFactory.java
@@ -20,7 +20,6 @@ package org.apache.commons.pool2;
import java.util.List;
import java.util.ArrayList;
-import org.apache.commons.pool2.PooledObjectFactory;
import org.apache.commons.pool2.impl.DefaultPooledObject;
/**
diff --git a/src/test/java/org/apache/commons/pool2/ObjectPoolIssue326.java b/src/test/java/org/apache/commons/pool2/ObjectPoolIssue326.java
index 39136f1..15286ea 100644
--- a/src/test/java/org/apache/commons/pool2/ObjectPoolIssue326.java
+++ b/src/test/java/org/apache/commons/pool2/ObjectPoolIssue326.java
@@ -24,8 +24,6 @@ import java.util.concurrent.Callable;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
-import org.apache.commons.pool2.BaseKeyedPooledObjectFactory;
-import org.apache.commons.pool2.PooledObject;
import org.apache.commons.pool2.impl.BaseObjectPoolConfig;
import org.apache.commons.pool2.impl.DefaultPooledObject;
import org.apache.commons.pool2.impl.GenericKeyedObjectPool;
diff --git a/src/test/java/org/apache/commons/pool2/TestObjectPool.java b/src/test/java/org/apache/commons/pool2/TestObjectPool.java
index d46bc40..e3aec68 100644
--- a/src/test/java/org/apache/commons/pool2/TestObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/TestObjectPool.java
@@ -18,8 +18,6 @@ package org.apache.commons.pool2;
import static org.junit.Assert.*;
-import org.apache.commons.pool2.ObjectPool;
-import org.apache.commons.pool2.PooledObjectFactory;
import org.apache.commons.pool2.impl.GenericObjectPool;
import org.apache.commons.pool2.impl.SoftReferenceObjectPool;
import org.junit.Test;
diff --git a/src/test/java/org/apache/commons/pool2/VisitTrackerFactory.java b/src/test/java/org/apache/commons/pool2/VisitTrackerFactory.java
index 8346655..75d0182 100644
--- a/src/test/java/org/apache/commons/pool2/VisitTrackerFactory.java
+++ b/src/test/java/org/apache/commons/pool2/VisitTrackerFactory.java
@@ -17,8 +17,6 @@
package org.apache.commons.pool2;
-import org.apache.commons.pool2.KeyedPooledObjectFactory;
-import org.apache.commons.pool2.PooledObjectFactory;
import org.apache.commons.pool2.impl.DefaultPooledObject;
/**
[commons-pool] 01/03: Use try-with-resource. Remove unused imports.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit aca566e6a2e01311e16b4aa02bbe84824fa75495
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Sep 23 22:16:49 2020 -0400
Use try-with-resource.
Remove unused imports.
---
.../commons/pool2/impl/AtomicIntegerFactory.java | 1 -
.../pool2/impl/TestBaseGenericObjectPool.java | 45 +++++++++++-----------
2 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/impl/AtomicIntegerFactory.java b/src/test/java/org/apache/commons/pool2/impl/AtomicIntegerFactory.java
index 803d1db..b0b9d1f 100644
--- a/src/test/java/org/apache/commons/pool2/impl/AtomicIntegerFactory.java
+++ b/src/test/java/org/apache/commons/pool2/impl/AtomicIntegerFactory.java
@@ -20,7 +20,6 @@ import java.util.concurrent.atomic.AtomicInteger;
import org.apache.commons.pool2.BasePooledObjectFactory;
import org.apache.commons.pool2.PooledObject;
-import org.apache.commons.pool2.impl.DefaultPooledObject;
/**
* Factory that sources PooledObjects that wrap AtomicIntegers.
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestBaseGenericObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestBaseGenericObjectPool.java
index 8c9f1fb..af06ac3 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestBaseGenericObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestBaseGenericObjectPool.java
@@ -71,36 +71,37 @@ public class TestBaseGenericObjectPool {
@Test
public void testActiveTimeStatistics() {
- for (int i = 0; i < 99; i++) { // must be < MEAN_TIMING_STATS_CACHE_SIZE
- pool.updateStatsReturn(i);
- }
- Assert.assertEquals(49, pool.getMeanActiveTimeMillis(), Double.MIN_VALUE);
+ for (int i = 0; i < 99; i++) { // must be < MEAN_TIMING_STATS_CACHE_SIZE
+ pool.updateStatsReturn(i);
+ }
+ Assert.assertEquals(49, pool.getMeanActiveTimeMillis(), Double.MIN_VALUE);
}
@Test
public void testEvictionTimerMultiplePools() throws InterruptedException {
final AtomicIntegerFactory factory = new AtomicIntegerFactory();
factory.setValidateLatency(50);
- final GenericObjectPool<AtomicInteger> evictingPool = new GenericObjectPool<>(factory);
- evictingPool.setTimeBetweenEvictionRunsMillis(100);
- evictingPool.setNumTestsPerEvictionRun(5);
- evictingPool.setTestWhileIdle(true);
- evictingPool.setMinEvictableIdleTimeMillis(50);
- for (int i = 0; i < 10; i++) {
- try {
- evictingPool.addObject();
- } catch (Exception e) {
- e.printStackTrace();
+ try (final GenericObjectPool<AtomicInteger> evictingPool = new GenericObjectPool<>(factory)) {
+ evictingPool.setTimeBetweenEvictionRunsMillis(100);
+ evictingPool.setNumTestsPerEvictionRun(5);
+ evictingPool.setTestWhileIdle(true);
+ evictingPool.setMinEvictableIdleTimeMillis(50);
+ for (int i = 0; i < 10; i++) {
+ try {
+ evictingPool.addObject();
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
}
- }
- for (int i = 0; i < 1000; i++) {
- final GenericObjectPool<AtomicInteger> nonEvictingPool = new GenericObjectPool<>(factory);
- nonEvictingPool.close();
- }
+ for (int i = 0; i < 1000; i++) {
+ try (final GenericObjectPool<AtomicInteger> nonEvictingPool = new GenericObjectPool<>(factory)) {
+ // empty
+ }
+ }
- Thread.sleep(1000);
- Assert.assertEquals(0, evictingPool.getNumIdle());
- evictingPool.close();
+ Thread.sleep(1000);
+ Assert.assertEquals(0, evictingPool.getNumIdle());
+ }
}
}
[commons-pool] 02/03: Remove unused.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit 131642f42ed36b5e41f6b49702e30f620289d1aa
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Sep 23 22:17:47 2020 -0400
Remove unused.
---
src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java | 4 +---
.../org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java b/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java
index 33b38c2..0b71f52 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestEvictionTimer.java
@@ -17,13 +17,11 @@
package org.apache.commons.pool2.impl;
import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
-import java.lang.ref.WeakReference;
import java.lang.reflect.Field;
-import java.util.HashMap;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
index e805a39..2514ab4 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
@@ -1067,7 +1067,7 @@ public class TestGenericKeyedObjectPool extends TestKeyedObjectPool {
* aware of this if you see a failure of this test.
*/
@SuppressWarnings({
- "rawtypes", "unchecked"
+ "rawtypes"
})
@Test(timeout=60000)
public void testBorrowObjectFairness() throws Exception {