You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/04/05 07:40:58 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #40673: [SPARK-41537][INFRA][CONNECT][FOLLOW-UP] Removes breaking changes within master branch
HyukjinKwon opened a new pull request, #40673:
URL: https://github.com/apache/spark/pull/40673
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/39294 that proposes to remove the breaking change detection within `master` branch.
### Why are the changes needed?
Apache Spark does not guarantee the compatibility between individual commits but between releases according to semantic versioning.
It would have been great if we can use this job as a sort of warning but this feature is missing in GitHub Actions. See also:
- https://github.com/actions/runner/issues/2347
- https://github.com/actions/runner/issues/2347
Therefore, we cannot use this as a warning.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Will be tested within my fork first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40673: [SPARK-41537][INFRA][CONNECT][FOLLOW-UP] Removes breaking changes within master branch
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40673:
URL: https://github.com/apache/spark/pull/40673#issuecomment-1501048604
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40673: [SPARK-41537][INFRA][CONNECT][FOLLOW-UP] Removes breaking changes within master branch
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40673: [SPARK-41537][INFRA][CONNECT][FOLLOW-UP] Removes breaking changes within master branch
URL: https://github.com/apache/spark/pull/40673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40673: [SPARK-41537][INFRA][CONNECT][FOLLOW-UP] Removes breaking changes within master branch
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #40673:
URL: https://github.com/apache/spark/pull/40673#discussion_r1158140990
##########
.github/workflows/build_and_test.yml:
##########
@@ -494,53 +495,12 @@ jobs:
name: test-results-sparkr--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"
- proto-breaking-changes-check-master:
+ breaking-changes-buf:
needs: [precondition]
- if: always() && fromJson(needs.precondition.outputs.required).proto-breaking-changes-check == 'true'
- name: Spark Connect proto backwards compatibility check (master)
- continue-on-error: true
+ if: always() && fromJson(needs.precondition.outputs.required).breaking-changes-buf == 'true'
+ # Change 'branch-3.4' to 'branch-3.5' in master branch after cutting branch-3.5 branch.
+ name: Breaking change detection with Buf (branch-3.4)
Review Comment:
This name, I got it from https://github.com/bufbuild/buf-breaking-action#buf-breaking-action README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40673: [SPARK-41537][INFRA][CONNECT][FOLLOW-UP] Removes breaking changes within master branch
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40673:
URL: https://github.com/apache/spark/pull/40673#issuecomment-1499780072
Will merge this in few days. Please let me know if there's any concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org