You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/12 10:13:59 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #17586: [fix][CI] Follow-up fix for don't run "Pulsar CI checks completed" too early

lhotari opened a new pull request, #17586:
URL: https://github.com/apache/pulsar/pull/17586

   ### Motivation
   
   - The "Pulsar CI checks completed" gets run too early also with #17584 changes
   
   - another solution is needed to make it work as expected
   
   ### Modifications
   
   - use `if: always()` and a solution where each required build is checked explicitly in a bash script. If the requirements aren't fulfilled, the script will fail with error code 1.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi merged pull request #17586: [fix][CI] Follow-up fix for don't run "Pulsar CI checks completed" too early

Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #17586:
URL: https://github.com/apache/pulsar/pull/17586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #17586: [fix][CI] Follow-up fix for don't run "Pulsar CI checks completed" too early

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17586:
URL: https://github.com/apache/pulsar/pull/17586#issuecomment-1243539051

   docs for "needs" context: https://docs.github.com/en/actions/learn-github-actions/contexts#needs-context
   
   thanks to @tisonkun for pointing out the solution in https://github.com/apache/pulsar/pull/17584#discussion_r967974810


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org