You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "bboyleonp666 (via GitHub)" <gi...@apache.org> on 2024/08/07 00:46:25 UTC
[PR] Fix ConcurrentModificationException caused by NioEchoServer.closeNewChannels [kafka]
bboyleonp666 opened a new pull request, #16817:
URL: https://github.com/apache/kafka/pull/16817
`NioEchoServer#closeNewChannels` did not handle multi-threading synchronization. Add `synchronized` handling to prevent `java.util.ConcurrentModificationException`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ConcurrentModificationException caused by NioEchoServer.closeNewChannels [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16817:
URL: https://github.com/apache/kafka/pull/16817#issuecomment-2273872458
> I found there's another method NioEchoServer#closeSocketChannels that might have potential risk like this one
nice finding. Please fix it in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17269 Fix ConcurrentModificationException caused by NioEchoServer.closeNewChannels [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16817:
URL: https://github.com/apache/kafka/pull/16817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ConcurrentModificationException caused by NioEchoServer.closeNewChannels [kafka]
Posted by "bboyleonp666 (via GitHub)" <gi...@apache.org>.
bboyleonp666 commented on PR #16817:
URL: https://github.com/apache/kafka/pull/16817#issuecomment-2272418055
While handling this issue, I found there's another method `NioEchoServer#closeSocketChannels` that might have potential risk like this one. It's now only used by 2 tests in `SslTransportLayerTest`, but since it's a public method, I think we should add the same thread safe protection for this one as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org