You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Ernie Rael (Jira)" <ji...@apache.org> on 2020/01/18 22:52:00 UTC

[jira] [Resolved] (NETBEANS-3674) BaseKit manipulates JTextComponent and NOT in EDT

     [ https://issues.apache.org/jira/browse/NETBEANS-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ernie Rael resolved NETBEANS-3674.
----------------------------------
    Fix Version/s: 11.3
       Resolution: Fixed

The pull request fix got rid of the Swing access when not in EDT that I was seeing.

> BaseKit manipulates JTextComponent and NOT in EDT
> -------------------------------------------------
>
>                 Key: NETBEANS-3674
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-3674
>             Project: NetBeans
>          Issue Type: Bug
>          Components: editor - Settings
>    Affects Versions: 11.2
>         Environment: jdk1,8, win7,11.2u1
>            Reporter: Ernie Rael
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 11.3
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> In editor.lib/.../BasKit.java a lookup listener does "c.setMap(keymap)". This is required to run in the EventDisplatchThread. KeybindingsAndPreferencesTracker::refreshShortcutsAndActions around line 4125
> For example:
>  "Editor-Setting-Files-Tracker-Keybindings"
> 	at org.netbeans.editor.BaseKit$KeybindingsAndPreferencesTracker.refreshShortcutsAndActions(BaseKit.java:4119)
> 	at org.netbeans.editor.BaseKit$KeybindingsAndPreferencesTracker.resultChanged(BaseKit.java:4081)
> 	...
> 	at org.netbeans.modules.editor.settings.storage.SettingsProvider$MyLookup.updateContents(SettingsProvider.java:275)
> 	at org.netbeans.modules.editor.settings.storage.SettingsProvider$MyLookup.propertyChange(SettingsProvider.java:188)
> 	at org.openide.util.WeakListenerImpl$PropertyChange.propertyChange(WeakListenerImpl.java:190)
> 	...
> 	at org.netbeans.modules.editor.settings.storage.keybindings.KeyBindingSettingsImpl$Listener.propertyChange(KeyBindingSettingsImpl.java:320)
> 	at java.beans.PropertyChangeSupport.fire(PropertyChangeSupport.java:335)
> 	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:327)
> 	at java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:263)
> 	at org.netbeans.modules.editor.settings.storage.api.EditorSettingsStorage$2.call(EditorSettingsStorage.java:104)
> 	at org.netbeans.modules.editor.settings.storage.api.EditorSettingsStorage$2.call(EditorSettingsStorage.java:102)
> 	at org.netbeans.modules.editor.settings.storage.StorageImpl.refresh(StorageImpl.java:170)
> 	at org.netbeans.modules.editor.settings.storage.StorageImpl$FilesystemTracker.run(StorageImpl.java:591)
> 	at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
> 	at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
> 	at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278)
> 	at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists