You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tharindu Mathew (JIRA)" <ji...@apache.org> on 2008/07/03 14:00:45 UTC

[jira] Created: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

fixes classes that failed a few MetalRootPane tests
---------------------------------------------------

                 Key: HARMONY-5894
                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Tharindu Mathew




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Tharindu Mathew (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tharindu Mathew updated HARMONY-5894:
-------------------------------------

    Attachment: MetalRootPaneTitlePaneFix.patch

modifies MetalRootPaneTitlePane to fix MetalRootPane tests

> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>         Attachments: BasicInternalFrameTitlePaneFix.patch, MetalInternalFrameTitlePaneFix.patch, MetalRootPaneTitlePaneFix.patch, MetalRootPaneUIFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Tharindu Mathew (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tharindu Mathew updated HARMONY-5894:
-------------------------------------

    Attachment: MetalRootPaneUIFix.patch

modifies MetalRootPaneUI to fix MetalRootPane tests

> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>         Attachments: BasicInternalFrameTitlePaneFix.patch, MetalInternalFrameTitlePaneFix.patch, MetalRootPaneTitlePaneFix.patch, MetalRootPaneUIFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Tharindu Mathew (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tharindu Mathew updated HARMONY-5894:
-------------------------------------

    Attachment: BasicInternalFrameTitlePaneFix.patch

modifies BasicInternalFrameTitlePane to fix MetalRootPane tests

> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>         Attachments: BasicInternalFrameTitlePaneFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610486#action_12610486 ] 

Alexei Fedotov commented on HARMONY-5894:
-----------------------------------------

Tharindu, I'm afraid a single shared root pane for all panes at src/main/java/common/javax/swing/plaf/metal/MetalRootPaneTitlePane.java is not what java design expects from this pattern. Any pane should be able to have its own root pane.



> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>            Assignee: Alexei Fedotov
>         Attachments: BasicInternalFrameTitlePaneFix.patch, MetalInternalFrameTitlePaneFix.patch, MetalRootPaneTitlePaneFix.patch, MetalRootPaneUIFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Tharindu Mathew (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tharindu Mathew updated HARMONY-5894:
-------------------------------------

    Attachment: MetalInternalFrameTitlePaneFix.patch

modifies MetalInternalFrameTitlePane to fix MetalRootPane tests

> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>         Attachments: BasicInternalFrameTitlePaneFix.patch, MetalInternalFrameTitlePaneFix.patch, MetalRootPaneTitlePaneFix.patch, MetalRootPaneUIFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610484#action_12610484 ] 

Alexei Fedotov commented on HARMONY-5894:
-----------------------------------------

Thanks, Tharindu. I'm reading the patches.

I have a small comment about occasional tabs in the  the patches. The standard Eclipse style needs to be adjusted to meet Harmony conventions by setting "Spaces only" and renaming profile name at Project Properties->Java Code Style->Formatter->Configure Workspace Settings...->Edit.



> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>            Assignee: Alexei Fedotov
>         Attachments: BasicInternalFrameTitlePaneFix.patch, MetalInternalFrameTitlePaneFix.patch, MetalRootPaneTitlePaneFix.patch, MetalRootPaneUIFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610488#action_12610488 ] 

Alexei Fedotov commented on HARMONY-5894:
-----------------------------------------

For me, all tests pass except MetalTabbedPaneUITest. Are you fixing this test or some of the excluded tests? 

> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>            Assignee: Alexei Fedotov
>         Attachments: BasicInternalFrameTitlePaneFix.patch, MetalInternalFrameTitlePaneFix.patch, MetalRootPaneTitlePaneFix.patch, MetalRootPaneUIFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5894) fixes classes that failed a few MetalRootPane tests

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov reassigned HARMONY-5894:
---------------------------------------

    Assignee: Alexei Fedotov

> fixes classes that failed a few MetalRootPane tests
> ---------------------------------------------------
>
>                 Key: HARMONY-5894
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5894
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Tharindu Mathew
>            Assignee: Alexei Fedotov
>         Attachments: BasicInternalFrameTitlePaneFix.patch, MetalInternalFrameTitlePaneFix.patch, MetalRootPaneTitlePaneFix.patch, MetalRootPaneUIFix.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.