You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "renato2099 (GitHub)" <gi...@apache.org> on 2018/08/25 15:15:18 UTC

[GitHub] [arrow] renato2099 opened pull request #2472: ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h

Simple patch for resolving https://issues.apache.org/jira/browse/ARROW-3017

[ Full content available at: https://github.com/apache/arrow/pull/2472 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #2472: ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h

Posted by "wesm (GitHub)" <gi...@apache.org>.
Need to remove this

[ Full content available at: https://github.com/apache/arrow/pull/2472 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [arrow] codecov-io commented on issue #2472: ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=h1) Report
> Merging [#2472](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=desc) into [master](https://codecov.io/gh/apache/arrow/commit/588c1faadf67e444817bd3accd8e5766eb0cf89a?src=pr&el=desc) will **increase** coverage by `1.27%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/2472/graphs/tree.svg?width=650&token=LpTCFbqVT1&height=150&src=pr)](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
+ Coverage   86.21%   87.48%   +1.27%     
==========================================
  Files         308      246      -62     
  Lines       46980    43311    -3669     
==========================================
- Hits        40502    37890    -2612     
+ Misses       6404     5421     -983     
+ Partials       74        0      -74
```


| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cpp/src/arrow/util/thread-pool.h](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Y3BwL3NyYy9hcnJvdy91dGlsL3RocmVhZC1wb29sLmg=) | `85.71% <0%> (-6.6%)` | :arrow_down: |
| [cpp/src/arrow/test-util.h](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Y3BwL3NyYy9hcnJvdy90ZXN0LXV0aWwuaA==) | `76.74% <0%> (-1.56%)` | :arrow_down: |
| [rust/src/record\_batch.rs](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-cnVzdC9zcmMvcmVjb3JkX2JhdGNoLnJz) | | |
| [go/arrow/datatype\_nested.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvZGF0YXR5cGVfbmVzdGVkLmdv) | | |
| [rust/src/array.rs](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-cnVzdC9zcmMvYXJyYXkucnM=) | | |
| [go/arrow/math/uint64\_amd64.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvbWF0aC91aW50NjRfYW1kNjQuZ28=) | | |
| [go/arrow/internal/testing/tools/bool.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvaW50ZXJuYWwvdGVzdGluZy90b29scy9ib29sLmdv) | | |
| [go/arrow/internal/bitutil/bitutil.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvaW50ZXJuYWwvYml0dXRpbC9iaXR1dGlsLmdv) | | |
| [go/arrow/memory/memory\_avx2\_amd64.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvbWVtb3J5L21lbW9yeV9hdngyX2FtZDY0Lmdv) | | |
| [rust/src/error.rs](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-cnVzdC9zcmMvZXJyb3IucnM=) | | |
| ... and [54 more](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=footer). Last update [588c1fa...3641146](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/arrow/pull/2472 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [arrow] renato2099 commented on pull request #2472: ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h

Posted by "renato2099 (GitHub)" <gi...@apache.org>.
I have update it @wesm 
Thanks!

[ Full content available at: https://github.com/apache/arrow/pull/2472 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [arrow] codecov-io commented on issue #2472: ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=h1) Report
> Merging [#2472](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=desc) into [master](https://codecov.io/gh/apache/arrow/commit/5a01af815de5e69ff8a592da0065cacdcf1f05cc?src=pr&el=desc) will **increase** coverage by `1.27%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/2472/graphs/tree.svg?width=650&token=LpTCFbqVT1&height=150&src=pr)](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
+ Coverage    86.2%   87.48%   +1.27%     
==========================================
  Files         308      246      -62     
  Lines       46980    43311    -3669     
==========================================
- Hits        40500    37890    -2610     
+ Misses       6406     5421     -985     
+ Partials       74        0      -74
```


| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cpp/src/arrow/util/thread-pool.h](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Y3BwL3NyYy9hcnJvdy91dGlsL3RocmVhZC1wb29sLmg=) | `85.71% <0%> (-6.6%)` | :arrow_down: |
| [rust/src/record\_batch.rs](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-cnVzdC9zcmMvcmVjb3JkX2JhdGNoLnJz) | | |
| [go/arrow/datatype\_nested.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvZGF0YXR5cGVfbmVzdGVkLmdv) | | |
| [rust/src/array.rs](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-cnVzdC9zcmMvYXJyYXkucnM=) | | |
| [go/arrow/math/uint64\_amd64.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvbWF0aC91aW50NjRfYW1kNjQuZ28=) | | |
| [go/arrow/internal/testing/tools/bool.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvaW50ZXJuYWwvdGVzdGluZy90b29scy9ib29sLmdv) | | |
| [go/arrow/internal/bitutil/bitutil.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvaW50ZXJuYWwvYml0dXRpbC9iaXR1dGlsLmdv) | | |
| [go/arrow/memory/memory\_avx2\_amd64.go](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-Z28vYXJyb3cvbWVtb3J5L21lbW9yeV9hdngyX2FtZDY0Lmdv) | | |
| [rust/src/error.rs](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-cnVzdC9zcmMvZXJyb3IucnM=) | | |
| [rust/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree#diff-cnVzdC9zcmMvbGliLnJz) | | |
| ... and [53 more](https://codecov.io/gh/apache/arrow/pull/2472/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=footer). Last update [5a01af8...c8ddaac](https://codecov.io/gh/apache/arrow/pull/2472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/arrow/pull/2472 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #2472: ARROW-3017: [C++] Don't throw exception in arrow/util/thread-pool.h

Posted by "pitrou (GitHub)" <gi...@apache.org>.
[ pull request closed by pitrou ]

[ Full content available at: https://github.com/apache/arrow/pull/2472 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org