You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/05/10 04:36:02 UTC
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22875
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
[util] replace BOOST_BINARY with 0bxxx notation
Since the codebase has switched to the C++17 standard a long time ago,
it's possible to use 0bxxx notation (available in C++14) instead
of BOOST_BINARY.
This changelist doesn't not contain any functional modifications.
Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
---
M src/kudu/tablet/concurrent_btree.h
M src/kudu/util/bit-util-test.cc
M src/kudu/util/group_varint-inl.h
M src/kudu/util/group_varint-test.cc
M src/kudu/util/group_varint.cc
M src/kudu/util/rle-test.cc
6 files changed, 29 insertions(+), 98 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/22875/1
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22875 )
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1359/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 10 May 2025 05:57:28 +0000
Gerrit-HasComments: No
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22875 )
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 12 May 2025 07:34:32 +0000
Gerrit-HasComments: No
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22875 )
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
Patch Set 1: Verified+1
unrelated test failures:
debug: delete_table-itest.3
tsan: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 12 May 2025 07:32:52 +0000
Gerrit-HasComments: No
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22875 )
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1359/
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 10 May 2025 04:36:11 +0000
Gerrit-HasComments: No
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22875 )
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
[util] replace BOOST_BINARY with 0bxxx notation
Since the codebase has switched to the C++17 standard a long time ago,
it's possible to use 0bxxx notation (available in C++14) instead
of BOOST_BINARY.
This changelist doesn't not contain any functional modifications.
Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Reviewed-on: http://gerrit.cloudera.org:8080/22875
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/tablet/concurrent_btree.h
M src/kudu/util/bit-util-test.cc
M src/kudu/util/group_varint-inl.h
M src/kudu/util/group_varint-test.cc
M src/kudu/util/group_varint.cc
M src/kudu/util/rle-test.cc
6 files changed, 29 insertions(+), 98 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [util] replace BOOST BINARY with 0bxxx notation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22875 )
Change subject: [util] replace BOOST_BINARY with 0bxxx notation
......................................................................
Patch Set 1:
Thanks you for review!
--
To view, visit http://gerrit.cloudera.org:8080/22875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb259c66ff6d2497e23bccfe6e3e75d996d32c6b
Gerrit-Change-Number: 22875
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 12 May 2025 16:42:34 +0000
Gerrit-HasComments: No