You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/28 17:31:24 UTC
[GitHub] [tvm] areusch opened a new pull request #8576: Enable pytest-xdist for TVM CI
areusch opened a new pull request #8576:
URL: https://github.com/apache/tvm/pull/8576
Enable pytest-xdist to paralellize CI jobs on worker nodes. The thought here is: right now our concurrency model in CI is to keep with 1 CPU to reduce debugging headache and run $(nproc) workers per CI CPU node. Meanwhile our CI is heterogenous so a long ci_cpu-bound step will negatively affect the overall runtime of all PRs. Going the other way, the idea is to run each CI job as fast as possible and let jobs pile into queues where we can see more clearly the bottlenecks. This means that when the queues are drained, devs get faster response times from the CI, and the CPU nodes should still be used optimally (or perhaps get a slight boost since caching may work better with fewer workloads).
Restricting to 2 CPUs since this is a test; in the future, CI_PYTEST_NUM_CPUS should be used to actually control from Jenkinsfile.
cc @tqchen @jroesch @Lunderberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi closed pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
masahi closed pull request #8576:
URL: https://github.com/apache/tvm/pull/8576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r733012527
##########
File path: tests/scripts/setup-pytest-env.sh
##########
@@ -32,7 +32,35 @@ export PYTHONPATH="${TVM_PATH}/python"
export TVM_PYTEST_RESULT_DIR="${TVM_PATH}/build/pytest-results"
mkdir -p "${TVM_PYTEST_RESULT_DIR}"
+if [ -n "${CI_CPUSET_NUM_CPUS-}" ]; then
+ # When the # of CPUs has been restricted (e.g. when --cpuset-cpus has been passed to docker by
+ # docker/bash.sh), explicitly use all available CPUs. This environment variable is set by
+ # docker/bash.sh when it sets --cpuset-cpus.
+ PYTEST_NUM_CPUS="${CI_CPUSET_NUM_CPUS}"
+else
+ # Else attempt to use $(nproc) - 1.
+ PYTEST_NUM_CPUS=$(nproc)
+ if [ -z "${PYTEST_NUM_CPUS}" ]; then
+ echo "WARNING: nproc failed; running pytest with only 1 CPU"
+ PYTEST_NUM_CPUS=1
+ elif [ ${PYTEST_NUM_CPUS} -gt 1 ]; then
+ PYTEST_NUM_CPUS=$(expr ${PYTEST_NUM_CPUS} - 1) # Don't nuke interactive work.
+ fi
+
+ # Don't use >4 CPUs--in general, we only use 4 CPUs in testing, so we want to retain this
Review comment:
Why 4 ?
Also would it be possible for us to specialize run_pytest to for certain subset of tests that we think could benefit from this. i.e. --parallel <some_number> ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r745244485
##########
File path: tests/scripts/setup-pytest-env.sh
##########
@@ -32,7 +32,35 @@ export PYTHONPATH="${TVM_PATH}/python"
export TVM_PYTEST_RESULT_DIR="${TVM_PATH}/build/pytest-results"
mkdir -p "${TVM_PYTEST_RESULT_DIR}"
+if [ -n "${CI_CPUSET_NUM_CPUS-}" ]; then
+ # When the # of CPUs has been restricted (e.g. when --cpuset-cpus has been passed to docker by
+ # docker/bash.sh), explicitly use all available CPUs. This environment variable is set by
+ # docker/bash.sh when it sets --cpuset-cpus.
+ PYTEST_NUM_CPUS="${CI_CPUSET_NUM_CPUS}"
+else
+ # Else attempt to use $(nproc) - 1.
+ PYTEST_NUM_CPUS=$(nproc)
+ if [ -z "${PYTEST_NUM_CPUS}" ]; then
+ echo "WARNING: nproc failed; running pytest with only 1 CPU"
+ PYTEST_NUM_CPUS=1
+ elif [ ${PYTEST_NUM_CPUS} -gt 1 ]; then
+ PYTEST_NUM_CPUS=$(expr ${PYTEST_NUM_CPUS} - 1) # Don't nuke interactive work.
+ fi
+
+ # Don't use >4 CPUs--in general, we only use 4 CPUs in testing, so we want to retain this
Review comment:
4 just relates to how we currently allocate Jenkins executors to CI nodes. what i really want to do is make it possible to use $(nproc) here always (so that each node is maximally used). however, initial tests indicate that there is a threshold after which nodes become RAM-limited.
can you clarify your second question? how would we leverage this better in the subset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r687273197
##########
File path: vta/python/vta/__init__.py
##########
@@ -29,8 +30,18 @@
__version__ = "0.1.0"
-# do not from tvm import topi when running vta.exec.rpc_server
-# to maintain minimum dependency on the board
-if sys.argv[0] not in ("-c", "-m"):
+_LOG = logging.getLogger(__name__)
+
+# do not from tvm import topi when __main__ is in vta_onboard
+# to maintain minimum Python dependencies on the board.
+# TODO(vta-team): move board-only logic imported above into vta_onboard.
Review comment:
This is likely no longer needed after my update https://github.com/apache/tvm/blob/main/vta/python/vta/__init__.py#L36, we should be able to use the original vta as it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r679429742
##########
File path: python/tvm/testing.py
##########
@@ -379,7 +379,7 @@ def _get_targets(target_str=None):
if len(target_str) == 0:
target_str = DEFAULT_TEST_TARGETS
- target_names = set(t.strip() for t in target_str.split(";") if t.strip())
+ target_names = list(sorted(set(t.strip() for t in target_str.split(";") if t.strip())))
Review comment:
A thought from this morning. Do we want to have the list in sorted order, or in the order specified by `target_str`? Either way would be deterministic, but I'd lean toward the latter so that we can have explicit control over the order of targets. We can get this behavior if we use a `dict` instead of a `set` for removing duplicates.
`target_names = list({t.strip():None for t in target_str.split(';') if t.strip()})`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r679512005
##########
File path: python/tvm/testing.py
##########
@@ -379,7 +379,7 @@ def _get_targets(target_str=None):
if len(target_str) == 0:
target_str = DEFAULT_TEST_TARGETS
- target_names = set(t.strip() for t in target_str.split(";") if t.strip())
+ target_names = list(sorted(set(t.strip() for t in target_str.split(";") if t.strip())))
Review comment:
ah yeah probably in order of target_str
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r687273197
##########
File path: vta/python/vta/__init__.py
##########
@@ -29,8 +30,18 @@
__version__ = "0.1.0"
-# do not from tvm import topi when running vta.exec.rpc_server
-# to maintain minimum dependency on the board
-if sys.argv[0] not in ("-c", "-m"):
+_LOG = logging.getLogger(__name__)
+
+# do not from tvm import topi when __main__ is in vta_onboard
+# to maintain minimum Python dependencies on the board.
+# TODO(vta-team): move board-only logic imported above into vta_onboard.
Review comment:
The introduction of a separate vta_board package is likely no longer needed after my update https://github.com/apache/tvm/blob/main/vta/python/vta/__init__.py#L36.
We should be able to use the original vta as it is. Would be great to do so if that is the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r687006171
##########
File path: tests/scripts/task_python_unittest.sh
##########
@@ -31,9 +32,9 @@ if [ -z "${TVM_UNITTEST_TESTSUITE_NAME:-}" ]; then
fi
# First run minimal test on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
# Then run all unittests on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
+run_pytest --parallel cython ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
Review comment:
i think you could do that with `CI_PYTEST_NUM_CPUS=1`, does that seem ok to you? i was going to consider also moving that logic into task_build.sh as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#issuecomment-1008435869
I assume this is superceded by https://github.com/apache/tvm/pull/9834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r688029941
##########
File path: vta/python/vta/__init__.py
##########
@@ -29,8 +30,18 @@
__version__ = "0.1.0"
-# do not from tvm import topi when running vta.exec.rpc_server
-# to maintain minimum dependency on the board
-if sys.argv[0] not in ("-c", "-m"):
+_LOG = logging.getLogger(__name__)
+
+# do not from tvm import topi when __main__ is in vta_onboard
+# to maintain minimum Python dependencies on the board.
+# TODO(vta-team): move board-only logic imported above into vta_onboard.
Review comment:
ah oops this was a bad merge, fixing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r686622440
##########
File path: tests/scripts/task_python_unittest.sh
##########
@@ -31,9 +32,9 @@ if [ -z "${TVM_UNITTEST_TESTSUITE_NAME:-}" ]; then
fi
# First run minimal test on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
# Then run all unittests on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
+run_pytest --parallel cython ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
Review comment:
Sorry for being late reviewing this PR. I was thinking whether we could make this `--parallel` here to be disabled somehow. I think it is OK and expected that it is enabled by default, but to make this scripts reusable, it would be great to have a way to disable things. Perhaps an environment variable is enough?
An idea would be standardising `$PYTEST_PARALLEL=ON|OFF ? YES|NO ? 1|0?` as the way to control that in all scripts, and document that.
(same comment applies to task_python_vta_fsim.sh and other in this same PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r687273197
##########
File path: vta/python/vta/__init__.py
##########
@@ -29,8 +30,18 @@
__version__ = "0.1.0"
-# do not from tvm import topi when running vta.exec.rpc_server
-# to maintain minimum dependency on the board
-if sys.argv[0] not in ("-c", "-m"):
+_LOG = logging.getLogger(__name__)
+
+# do not from tvm import topi when __main__ is in vta_onboard
+# to maintain minimum Python dependencies on the board.
+# TODO(vta-team): move board-only logic imported above into vta_onboard.
Review comment:
The introduction of a separate vta_board package is likely no longer needed after my update https://github.com/apache/tvm/blob/main/vta/python/vta/__init__.py#L36, we should be able to use the original vta as it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r681741480
##########
File path: tests/scripts/task_python_unittest.sh
##########
@@ -31,9 +31,9 @@ if [ -z "${TVM_UNITTEST_TESTSUITE_NAME:-}" ]; then
fi
# First run minimal test on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
Review comment:
Confirmed this change is in place, looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r687082451
##########
File path: tests/scripts/task_python_unittest.sh
##########
@@ -31,9 +32,9 @@ if [ -z "${TVM_UNITTEST_TESTSUITE_NAME:-}" ]; then
fi
# First run minimal test on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
# Then run all unittests on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
+run_pytest --parallel cython ${TVM_UNITTEST_TESTSUITE_NAME} tests/python/unittest
Review comment:
Yes, that works! I missed it from the scripts. Can we document that somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r678589727
##########
File path: tests/scripts/setup-pytest-env.sh
##########
@@ -32,7 +32,33 @@ export PYTHONPATH="${TVM_PATH}/python"
export TVM_PYTEST_RESULT_DIR="${TVM_PATH}/build/pytest-results"
mkdir -p "${TVM_PYTEST_RESULT_DIR}"
+if [ -n "${CI_PYTEST_NUM_CPUS-}" ]; then
+ PYTEST_NUM_CPUS=${CI_PYTEST_NUM_CPUS}
+else
+ PYTEST_NUM_CPUS=$(nproc)
+ if [ -z "${PYTEST_NUM_CPUS}" ]; then
+ PYTEST_NUM_CPUS=1
+ elif [ ${PYTEST_NUM_CPUS} -gt 1 ]; then
+ PYTEST_NUM_CPUS=$(expr ${PYTEST_NUM_CPUS} - 1) # Don't nuke interactive work.
+ fi
+fi
+
+if [ ${PYTEST_NUM_CPUS} -gt 8 ]; then
+ PYTEST_NUM_CPUS=8 # It usually doesn't make sense to launch > 8 workers
+fi
+
+# DNS: remove after we actually fix up CI_PYTEST_NUM_CPUS in Jenkinsfile
+if [ ${PYTEST_NUM_CPUS} -gt 2 ]; then
+ PYTEST_NUM_CPUS=2 # Fix to 2 CPUs for Jenkins
+fi
+
+
function run_pytest() {
+ local extra_args=( )
+ if [ "$1" == "--parallel" ]; then
Review comment:
Since the documentation [currently recommends](https://github.com/apache/tvm/blob/main/docs/contribute/pull_request.rst#L121) using `task_python_unittest.sh` to run the unit tests, we should either make sure that location also has `pytest-xdist` in the list of packages to install in order to run the tests, or check whether `pytest-xdist` is installed by wrapping this in `if python3 -c "import xdist" > /dev/null 2>&1; then`.
##########
File path: tests/scripts/task_python_unittest.sh
##########
@@ -31,9 +31,9 @@ if [ -z "${TVM_UNITTEST_TESTSUITE_NAME:-}" ]; then
fi
# First run minimal test on both ctypes and cython.
-run_pytest ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
-run_pytest cython ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
+run_pytest --parallel ctypes ${TVM_UNITTEST_TESTSUITE_NAME}-platform-minimal-test tests/python/all-platform-minimal-test
Review comment:
Looks like this applies to everything in the unittest directory, including `test_tvm_testing_features.py`. I don't see the [explicit ordering](https://github.com/apache/tvm/pull/8343#discussion_r660038825) that will be required for some of those tests, so we should add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #8576: Enable pytest-xdist for TVM CI
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r687273197
##########
File path: vta/python/vta/__init__.py
##########
@@ -29,8 +30,18 @@
__version__ = "0.1.0"
-# do not from tvm import topi when running vta.exec.rpc_server
-# to maintain minimum dependency on the board
-if sys.argv[0] not in ("-c", "-m"):
+_LOG = logging.getLogger(__name__)
+
+# do not from tvm import topi when __main__ is in vta_onboard
+# to maintain minimum Python dependencies on the board.
+# TODO(vta-team): move board-only logic imported above into vta_onboard.
Review comment:
This is likely no longer needed after my update https://github.com/apache/tvm/blob/main/vta/python/vta/__init__.py#L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org