You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/01/16 20:40:20 UTC
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #618:
Fix #Build time FactoryFinders
ppalaga commented on a change in pull request #618: Fix #Build time FactoryFinders
URL: https://github.com/apache/camel-quarkus/pull/618#discussion_r367638712
##########
File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##########
@@ -128,9 +130,40 @@ void coreServiceFilter(BuildProducer<CamelServiceFilterBuildItem> filterBuildIte
}
@BuildStep
- void serviceInfoTransformers(BuildProducer<CamelServiceInfoTransformerBuildItem> mapperBuildItems) {
- mapperBuildItems.produce(
- new CamelServiceInfoTransformerBuildItem(CamelServiceInfoTransformers::configurer));
+ void coreServices(
+ ApplicationArchivesBuildItem archives,
+ BuildProducer<CamelServiceBuildItem> services) {
+
+ /* Registered only */
+ CamelSupport.propertyFiles(
+ archives,
+ "META-INF/services/org/apache/camel/component",
+ "META-INF/services/org/apache/camel/language",
+ "META-INF/services/org/apache/camel/dataformat")
Review comment:
> we need to fine tune language and data-format
Not sure how should we tune?
> as we can store into the registry only singleton services
You seem to imply language and data-format are not singleton services, but could you plz. define "singleton services"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services