You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/16 10:41:40 UTC
[GitHub] [incubator-pekko] Claudenw opened a new issue, #51: Update Git rules to follow work pattern.
Claudenw opened a new issue, #51:
URL: https://github.com/apache/incubator-pekko/issues/51
The github rules should not allow merging of pull requests when there are
1. open changes requested.
2. ongoing conversations (not resolved conversations).
I am not certain how to configure this on the Apache git system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] sam-byng commented on issue #51: Update Git rules to follow work pattern.
Posted by "sam-byng (via GitHub)" <gi...@apache.org>.
sam-byng commented on issue #51:
URL: https://github.com/apache/incubator-pekko/issues/51#issuecomment-1507272267
@mdedetrich seems like we've got a resolution on this now, with the mandatory single reviewer . Could this be closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich closed issue #51: Update Git rules to follow work pattern.
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #51: Update Git rules to follow work pattern.
URL: https://github.com/apache/incubator-pekko/issues/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #51: Update Git rules to follow work pattern.
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on issue #51:
URL: https://github.com/apache/incubator-pekko/issues/51#issuecomment-1318728338
Especially with point 2, this to me I think this is too strict. I have been in cases where pull requests stuck open in perpetuity because someone forgets to click the "resolve" button. Either that or committers will just blindly hit resolve which at that point defeats the purpose of it.
Should we discuss in the mailing list? I think for now this is fine, we can always add stricter checks later if there is a consensus on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Claudenw commented on issue #51: Update Git rules to follow work pattern.
Posted by GitBox <gi...@apache.org>.
Claudenw commented on issue #51:
URL: https://github.com/apache/incubator-pekko/issues/51#issuecomment-1316789499
pj assigning to you because you seem to have the experience in this realm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on issue #51: Update Git rules to follow work pattern.
Posted by GitBox <gi...@apache.org>.
pjfanning commented on issue #51:
URL: https://github.com/apache/incubator-pekko/issues/51#issuecomment-1316803609
The documented features are at https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features - I'll look later to see if I can spot something that we can use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org