You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/05 08:30:56 UTC
[GitHub] [iceberg] sunchao opened a new pull request #2299: Core: move targetSplitSize() to TableScan interface
sunchao opened a new pull request #2299:
URL: https://github.com/apache/iceberg/pull/2299
Currently `targetSplitSize` is a private method in `BaseTableScan`. However, currently both `SparkBatchQueryScan` (from #2276) and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, this PR moves it to `TableScan` and makes it public. In addition, this removes the parameter `TableOperations` from the method and replaces it with `tableOps()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] sunchao commented on pull request #2299: Core: move targetSplitSize() to TableScan interface
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #2299:
URL: https://github.com/apache/iceberg/pull/2299#issuecomment-792209608
Thanks @rdsr ! I'll going to try a different approach in #2276 as people suggested. Depending on the result, we may no longer need this change. I'll update here later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2299: Core: move targetSplitSize() to TableScan interface
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2299:
URL: https://github.com/apache/iceberg/pull/2299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org