You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 09:36:30 UTC
[I] [Bug] Consumer group delete should validate request name [rocketmq-dashboard]
Aias00 opened a new issue, #842:
URL: https://github.com/apache/rocketmq-dashboard/issues/842
### Problem
The Studio consumer group delete endpoint accepts a raw `Map<String, String>` request body and directly calls `request.get("name")`:
- `server/src/main/java/org/apache/rocketmq/studio/instance/group/ConsumerGroupController.java`
A request such as `{}` passes controller binding but forwards `null` to `MetadataService.deleteConsumerGroup`. That can produce provider-specific failures or misleading success/error behavior instead of a consistent 400 validation response.
This is different from related delete endpoints such as Topic and Instance, which already use typed request DTOs with validation.
### Expected behavior
`POST /api/groups/delete` should reject missing or blank `name` before invoking metadata/admin services, and return a structured 400 response.
### Suggested fix
Add a typed delete request DTO with `@NotBlank(message = "name is required")`, update the controller to use `@Valid @RequestBody`, and add controller tests for valid and missing-name requests.
### Scope
RocketMQ Studio / BASE-01 consumer group management request validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Consumer group delete should validate request name [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #842: [Bug] Consumer group delete should validate request name
URL: https://github.com/apache/rocketmq-dashboard/issues/842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Consumer group delete should validate request name [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #842:
URL: https://github.com/apache/rocketmq-dashboard/issues/842#issuecomment-5177566591
Resolved by #930 (merged into rocketmq-studio as 8e2c1c1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org