[GitHub] zhreshold commented on a change in pull request #13452: Get the correct include path in pip package

[GitBox <gi...@apache.org>]

zhreshold commented on a change in pull request #13452: Get the correct include path in pip package
URL: https://github.com/apache/incubator-mxnet/pull/13452#discussion_r237590190
 
 

 ##########
 File path: python/mxnet/libinfo.py
 ##########
 @@ -97,9 +97,16 @@ def find_include_path():
 
     curr_path = os.path.dirname(os.path.abspath(os.path.expanduser(__file__)))
     incl_path = os.path.join(curr_path, '../../include/')
-    if not os.path.isdir(incl_path):
-        raise RuntimeError('Cannot find the MXNet include path.\n')
-    return incl_path
+    if os.path.isdir(incl_path):
+        # include path if build from source
+        return incl_path
+    else:
+        incl_path = os.path.join(curr_path, '../include/')
 
 Review comment:
   does pip package really have a include directory?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services