[GitHub] [iceberg] hmit commented on pull request #5126: Parquet: Release the compressor when calling close in ParquetWriter

[GitBox <gi...@apache.org>]

hmit commented on PR #5126:
URL: https://github.com/apache/iceberg/pull/5126#issuecomment-1165787979

   > +1. Good catch @hmit!
   > 
   > I tried to find a place where this could be tested, but there didn't seem to be anywhere that was already testing whether or not things were closed so I think it's fine without it.
   
   Yeah, I didn't find a good unit-test to add this to. However, we did test it by deploying (with brotli compression) and it seems to do the trick.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org