You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Jargon9 (via GitHub)" <gi...@apache.org> on 2023/01/27 15:34:39 UTC
[GitHub] [rocketmq-streams] Jargon9 opened a new pull request, #259: [ISSUE #251]Support avg function in WindowStream
Jargon9 opened a new pull request, #259:
URL: https://github.com/apache/rocketmq-streams/pull/259
Hi teams, I have completed the main part of avg calculation. Could you please review the code?
- I wrote an example to test. Here is the test result.
`time:23:00:55.749, input:5
time:23:00:58.644, input:6
time:23:00:59.883, input:7
time:23:01:01.492, input:8
[2023-01-27 23:00:55 - 2023-01-27 23:01:00](key=key, value=6.0)
time:23:01:13.550, input:9
[2023-01-27 23:01:00 - 2023-01-27 23:01:05](key=key, value=8.0)`
- Besides, I'm a little confused. For the average calculation in the Accumulator, is the merge only allowed for the same type accumulator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] codecov-commenter commented on pull request #259: [ISSUE #251]Support avg function in WindowStream
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #259:
URL: https://github.com/apache/rocketmq-streams/pull/259#issuecomment-1417969205
# [Codecov](https://codecov.io/gh/apache/rocketmq-streams/pull/259?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#259](https://codecov.io/gh/apache/rocketmq-streams/pull/259?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6eec5d) into [develop](https://codecov.io/gh/apache/rocketmq-streams/commit/608ccaec83c458c625c25725320069f9748e80c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (608ccae) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #259 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 85 87 +2
Lines 3027 3084 +57
Branches 296 301 +5
=======================================
- Misses 3027 3084 +57
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-streams/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eams/core/function/accumulator/AvgAccumulator.java](https://codecov.io/gh/apache/rocketmq-streams/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9jb3JlL2Z1bmN0aW9uL2FjY3VtdWxhdG9yL0F2Z0FjY3VtdWxhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ocketmq/streams/core/rstream/WindowStreamImpl.java](https://codecov.io/gh/apache/rocketmq-streams/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9jb3JlL3JzdHJlYW0vV2luZG93U3RyZWFtSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../rocketmq/streams/core/util/OperatorNameMaker.java](https://codecov.io/gh/apache/rocketmq-streams/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9jb3JlL3V0aWwvT3BlcmF0b3JOYW1lTWFrZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...he/rocketmq/streams/examples/window/WindowAvg.java](https://codecov.io/gh/apache/rocketmq-streams/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhhbXBsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc3RyZWFtcy9leGFtcGxlcy93aW5kb3cvV2luZG93QXZnLmphdmE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze merged pull request #259: [ISSUE #251]Support avg function in WindowStream
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze merged PR #259:
URL: https://github.com/apache/rocketmq-streams/pull/259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #259: [ISSUE #251]Support avg function in WindowStream
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #259:
URL: https://github.com/apache/rocketmq-streams/pull/259#issuecomment-1409943255
>
Good catch, Thanks very much your pr.
1. merge is a reserved method, It use to merge two AvgAccumulator during calculation process；
2. the result of example seems not very accurate，pr 263 maybe solve this problem, please check this example again after that pr merged；
3. It is best to stop the RocketMQStream when program exit，like other examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #259: [ISSUE #251]Support avg function in WindowStream
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #259:
URL: https://github.com/apache/rocketmq-streams/pull/259#issuecomment-1417953811
Hi teams, I found that the log truncation of the previous results is incomplete. I retested the function. It should be OK.
Besides, thank you for your help, I add a WindowAvg-shutdown-hood when program exit , like other examples.
```
time:21:54:12.507, input:1
time:21:54:17.498, input:2
[2023-02-05 21:54:00 - 2023-02-05 21:54:15](key=key, value=1.0)
time:21:54:22.507, input:3
time:21:54:27.516, input:4
time:21:54:32.531, input:5
[2023-02-05 21:54:15 - 2023-02-05 21:54:30](key=key, value=3.0)
time:21:54:37.538, input:6
time:21:54:42.545, input:7
time:21:54:47.560, input:8
[2023-02-05 21:54:30 - 2023-02-05 21:54:45](key=key, value=6.0)
time:21:54:52.571, input:9
time:21:55:44.630, input:1
[2023-02-05 21:54:45 - 2023-02-05 21:55:00](key=key, value=8.5)
time:21:55:48.642, input:2
[2023-02-05 21:55:30 - 2023-02-05 21:55:45](key=key, value=1.0)
time:21:55:52.651, input:3
time:21:55:56.657, input:4
time:21:56:00.669, input:5
[2023-02-05 21:55:45 - 2023-02-05 21:56:00](key=key, value=3.0)
time:21:56:04.677, input:6
time:21:56:08.681, input:7
time:21:56:12.691, input:8
time:21:56:16.701, input:9
[2023-02-05 21:56:00 - 2023-02-05 21:56:15](key=key, value=6.5)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] ni-ze commented on pull request #259: [ISSUE #251]Support avg function in WindowStream
Posted by "ni-ze (via GitHub)" <gi...@apache.org>.
ni-ze commented on PR #259:
URL: https://github.com/apache/rocketmq-streams/pull/259#issuecomment-1415352237
@Jargon9 你好，能否看看这个pr，最近可能发版本，能带上最好。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] Jargon9 commented on pull request #259: [ISSUE #251]Support avg function in WindowStream
Posted by "Jargon9 (via GitHub)" <gi...@apache.org>.
Jargon9 commented on PR #259:
URL: https://github.com/apache/rocketmq-streams/pull/259#issuecomment-1416029140
> @Jargon9 你好，能否看看这个pr，最近可能发版本，能带上最好。
好的！感谢帮忙cr代码。不好意思我前几天有点忙，周末会继续完成它的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org