You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Joseph Sillitoe (JIRA)" <ji...@apache.org> on 2010/06/02 08:48:36 UTC

[jira] Created: (VYSPER-206) Implement XEP-0012: Last Activity

Implement XEP-0012: Last Activity
---------------------------------

                 Key: VYSPER-206
                 URL: https://issues.apache.org/jira/browse/VYSPER-206
             Project: VYSPER
          Issue Type: New Feature
          Components: extension
            Reporter: Joseph Sillitoe


XEP-0012: Last Activity is an extension specified at http://xmpp.org/extensions/xep-0012.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (VYSPER-206) Implement XEP-0012: Last Activity

Posted by "Joseph Sillitoe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VYSPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874945#action_12874945 ] 

Joseph Sillitoe commented on VYSPER-206:
----------------------------------------

Thank you,  I'll work on the persistence manager and the unit tests.

> Implement XEP-0012: Last Activity
> ---------------------------------
>
>                 Key: VYSPER-206
>                 URL: https://issues.apache.org/jira/browse/VYSPER-206
>             Project: VYSPER
>          Issue Type: New Feature
>          Components: extension
>            Reporter: Joseph Sillitoe
>         Attachments: namespaceuris_patch.txt, xep0012.tar.gz
>
>
> XEP-0012: Last Activity is an extension specified at http://xmpp.org/extensions/xep-0012.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (VYSPER-206) Implement XEP-0012: Last Activity

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VYSPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874511#action_12874511 ] 

Niklas Gustavsson commented on VYSPER-206:
------------------------------------------

First review of the patch is very positive. Code looks good. Some comments:
* We need unit tests for the implementation
* An in-memory persistence manager would be useful to make it possible to run the module

> Implement XEP-0012: Last Activity
> ---------------------------------
>
>                 Key: VYSPER-206
>                 URL: https://issues.apache.org/jira/browse/VYSPER-206
>             Project: VYSPER
>          Issue Type: New Feature
>          Components: extension
>            Reporter: Joseph Sillitoe
>         Attachments: namespaceuris_patch.txt, xep0012.tar.gz
>
>
> XEP-0012: Last Activity is an extension specified at http://xmpp.org/extensions/xep-0012.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (VYSPER-206) Implement XEP-0012: Last Activity

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VYSPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897963#action_12897963 ] 

Niklas Gustavsson commented on VYSPER-206:
------------------------------------------

Joesph, did you get anywhere further on this feature? Would love to get it into the code base :-)

> Implement XEP-0012: Last Activity
> ---------------------------------
>
>                 Key: VYSPER-206
>                 URL: https://issues.apache.org/jira/browse/VYSPER-206
>             Project: VYSPER
>          Issue Type: New Feature
>          Components: extension
>            Reporter: Joseph Sillitoe
>         Attachments: namespaceuris_patch.txt, xep0012.tar.gz
>
>
> XEP-0012: Last Activity is an extension specified at http://xmpp.org/extensions/xep-0012.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (VYSPER-206) Implement XEP-0012: Last Activity

Posted by "Joseph Sillitoe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VYSPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joseph Sillitoe updated VYSPER-206:
-----------------------------------

    Attachment: xep0012.tar.gz
                namespaceuris_patch.txt

The archive has the files needed to implement the extension (minus a persistence manager implementation).  The patch is for the NameSpaceURIs.java class to include the namespace.

> Implement XEP-0012: Last Activity
> ---------------------------------
>
>                 Key: VYSPER-206
>                 URL: https://issues.apache.org/jira/browse/VYSPER-206
>             Project: VYSPER
>          Issue Type: New Feature
>          Components: extension
>            Reporter: Joseph Sillitoe
>         Attachments: namespaceuris_patch.txt, xep0012.tar.gz
>
>
> XEP-0012: Last Activity is an extension specified at http://xmpp.org/extensions/xep-0012.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (VYSPER-206) Implement XEP-0012: Last Activity

Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VYSPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876041#action_12876041 ] 

Bernd Fondermann commented on VYSPER-206:
-----------------------------------------

I'd like to propose the following improvements/changes:

+ Do not forward last-activity IQ GETs to the client. Do all handling by the server.
+ let's not add extra logic to the PersistenceManager for finding out if requester is authorized
  Instead, we could quite easily derive this info using the RosterManager, e.g. see PersistenceAvailabilityHandler + RosterUtils
+ let's re-use existing StorageProviders for recording a. login time, b. logout time, c. last presence on logout, probably by adding methods to interface UserAuthorization
+ to make this XEP work, we would need to add code to post login and post logout. No hooks currently exist for doing that. We would need to take a closer look where to best do that.

Many thanks for contributing!





> Implement XEP-0012: Last Activity
> ---------------------------------
>
>                 Key: VYSPER-206
>                 URL: https://issues.apache.org/jira/browse/VYSPER-206
>             Project: VYSPER
>          Issue Type: New Feature
>          Components: extension
>            Reporter: Joseph Sillitoe
>         Attachments: namespaceuris_patch.txt, xep0012.tar.gz
>
>
> XEP-0012: Last Activity is an extension specified at http://xmpp.org/extensions/xep-0012.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (VYSPER-206) Implement XEP-0012: Last Activity

Posted by "Joseph Sillitoe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/VYSPER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874465#action_12874465 ] 

Joseph Sillitoe commented on VYSPER-206:
----------------------------------------

This is my first attempt to contribute to well.. any OS project, so please be gentle  :)

> Implement XEP-0012: Last Activity
> ---------------------------------
>
>                 Key: VYSPER-206
>                 URL: https://issues.apache.org/jira/browse/VYSPER-206
>             Project: VYSPER
>          Issue Type: New Feature
>          Components: extension
>            Reporter: Joseph Sillitoe
>         Attachments: namespaceuris_patch.txt, xep0012.tar.gz
>
>
> XEP-0012: Last Activity is an extension specified at http://xmpp.org/extensions/xep-0012.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.