[GitHub] [iceberg] rdblue commented on a diff in pull request #5389: Python: Refactor expression hierarchy

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5389:
URL: https://github.com/apache/iceberg/pull/5389#discussion_r933881302


##########
python/tests/expressions/test_expressions_base.py:
##########
@@ -208,9 +208,9 @@ def test_notnan_bind_nonfloat():
 @pytest.mark.parametrize(
     "op, string",
     [
-        (base.And(ExpressionA(), ExpressionB()), "And(testexpra, testexprb)"),
-        (base.Or(ExpressionA(), ExpressionB()), "Or(testexpra, testexprb)"),
-        (base.Not(ExpressionA()), "Not(testexpra)"),
+        (base.And(ExpressionA(), ExpressionB()), "And(left=ExpressionA(), right=ExpressionB())"),
+        (base.Or(ExpressionA(), ExpressionB()), "Or(left=ExpressionA(), right=ExpressionB())"),
+        (base.Not(ExpressionA()), "Not(child=ExpressionA())"),

Review Comment:
   I didn't make that change because I think it is easier to understand what's happening when we use less magic. Using `getfixturevalue` makes it clear that this is getting a fixture called "table_schema_simple". Otherwise where that comes from is magic and confusing (at least to me).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org