[GitHub] tzulitai commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family

[GitBox <gi...@apache.org>]

tzulitai commented on a change in pull request #7658: [FLINK-10493][core] Migrating the TupleSerializerBase serializers family
URL: https://github.com/apache/flink/pull/7658#discussion_r255369936
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerConfigSnapshot.java
 ##########
 @@ -155,4 +158,38 @@ else if (serializer instanceof UnloadableDummyTypeSerializer) {
 				TypeSerializerSchemaCompatibility.incompatible() :
 				TypeSerializerSchemaCompatibility.compatibleAsIs();
 	}
+
+	/**
+	 * SelfResolving assists with the migration path to the new serialization abstraction.
+	 *
+	 * <p>Previously some {@link TypeSerializer}s were reusing the same {@link TypeSerializerConfigSnapshot} class in
 
 Review comment:
   For this paragraph, I would suggest to simply imply that it can be used for general cases where the `ensureCompatibility` method cannot be removed. The fact that some of our serializers were sharing the same `TypeSerializerConfigSnapshot` class, as mentioned here, is only one of the possible reasons.
   Another reason, as we discussed before, is that users were using a Flink-shipped serializer before and does not have access to the serializer class in user code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services