You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Shally-Katariya (via GitHub)" <gi...@apache.org> on 2026/06/25 12:38:43 UTC

[PR] GH-50236: Remove obsolete OpenSUSE 15.5 workarounds [arrow]

Shally-Katariya opened a new pull request, #50258:
URL: https://github.com/apache/arrow/pull/50258

   ### Rationale for this change
   
   Apache Arrow no longer supports the OpenSUSE 15.5 build configuration that required explicit `shared_ptr` and `unique_ptr` constructions.
   
   This PR removes obsolete OpenSUSE 15.5-specific workarounds and simplifies the affected return statements by relying on standard implicit conversions.
   
   ### What changes are included in this PR?
   
   * Removed OpenSUSE 15.5-specific workaround comments.
   * Replaced explicit `std::shared_ptr<T>(std::move(...))` constructions with direct returns.
   * Replaced explicit `std::unique_ptr<T>(std::move(...))` constructions with direct returns.
   * Simplified code in the affected Arrow C++ source files without changing functionality.
   
   ### Are these changes tested?
   
   Yes.
   
   The changes were verified by building the affected components and running the relevant compute test suite:
   
   ```bash
   ninja arrow-compute-tests
   ctest -R "arrow-compute" --output-on-failure
   ```
   
   All tests passed successfully.
   
   ### Are there any user-facing changes?
   
   No. This change is an internal code cleanup and does not affect public APIs, behavior, or user-facing functionality.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50236: [C++] Remove obsolete OpenSUSE 15.5 workarounds [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #50258:
URL: https://github.com/apache/arrow/pull/50258#issuecomment-4852752837

   Thank you @Shally-Katariya !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50236: [C++] Remove obsolete OpenSUSE 15.5 workarounds [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #50258:
URL: https://github.com/apache/arrow/pull/50258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50236: Remove obsolete OpenSUSE 15.5 workarounds [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #50258:
URL: https://github.com/apache/arrow/pull/50258#issuecomment-4799363139

   @Shally-Katariya Can you fix the C++ formatting? You should be able to do it using `pre-commit run -a cpp`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org