You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2011/07/14 12:25:23 UTC
svn commit: r1146635 - /subversion/branches/1.7.x/STATUS
Author: julianfoad
Date: Thu Jul 14 10:25:23 2011
New Revision: 1146635
URL: http://svn.apache.org/viewvc?rev=1146635&view=rev
Log:
* STATUS: Nominate r1146620; vote and approve r1146492 group.
Modified:
subversion/branches/1.7.x/STATUS
Modified: subversion/branches/1.7.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1146635&r1=1146634&r2=1146635&view=diff
==============================================================================
--- subversion/branches/1.7.x/STATUS (original)
+++ subversion/branches/1.7.x/STATUS Thu Jul 14 10:25:23 2011
@@ -23,17 +23,15 @@ Candidate changes:
+1: danielsh
-0: cmpilato, rhuijben, gstein (problem is with callers,
not implementation)
-
- * r1146492, r1146555
- Add const to a couple members of svn_client_info2_t
- Justification:
- We don't want clients to think they can modify the underlying
- structures. We had similar problems with the svn_wc_status_t,
- and it makes it hard to rev APIs when clients may be monkeying
- with the data we pass along.
+
+ * r1146620
+ Simple consistency for the 'svn_client_info2_t' structure; no functional
+ change. On the 'wc_info' member, remove 'struct' keyword, as we don't
+ use it in any other similar situation.
+ Notes:
+ This change also marks the doc string for Doxygen, an 'obvious fix'.
Votes:
- +1: gstein, rhuijben
- +1: blair (voted on r1146492 only)
+ +1: julianfoad
Approved changes:
@@ -70,3 +68,15 @@ Approved changes:
Resolve regression and remove confusion by future callers.
Votes:
+1: rhuijben, gstein, stsp
+
+ * r1146492, r1146555
+ Add const to a couple members of svn_client_info2_t
+ Justification:
+ We don't want clients to think they can modify the underlying
+ structures. We had similar problems with the svn_wc_status_t,
+ and it makes it hard to rev APIs when clients may be monkeying
+ with the data we pass along.
+ Votes:
+ +1: gstein, rhuijben, julianfoad
+ +1: blair (voted on r1146492 only)
+