You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/23 07:30:48 UTC

[GitHub] [shardingsphere] Lucas-307 opened a new pull request #8301: Refactoring DataSourceConfiguration

Lucas-307 opened a new pull request #8301:
URL: https://github.com/apache/shardingsphere/pull/8301


   Changes proposed in this pull request:
   - Add config/datasource package
   - Optimize DataSourceConfiguration
   - Optimize DataSourceFactory
   - Rename variable Configuration to Config
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8301: Refactoring DataSource Configuration

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8301:
URL: https://github.com/apache/shardingsphere/pull/8301#issuecomment-732053212


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=h1) Report
   > Merging [#8301](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=desc) (a75d223) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5687ee847b30511b2b8269e29f6a96a051fa5827?el=desc) (5687ee8) will **increase** coverage by `0.00%`.
   > The diff coverage is `74.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8301/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #8301   +/-   ##
   =========================================
     Coverage     74.73%   74.74%           
   + Complexity      600      599    -1     
   =========================================
     Files          1483     1483           
     Lines         23431    23420   -11     
     Branches       4174     4169    -5     
   =========================================
   - Hits          17512    17505    -7     
   + Misses         4768     4766    -2     
   + Partials       1151     1149    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apache/shardingsphere/scaling/ServerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9TZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...apache/shardingsphere/scaling/WorkerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9Xb3JrZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...phere/scaling/core/config/DumperConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvRHVtcGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ere/scaling/core/config/ImporterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvSW1wb3J0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...re/scaling/elasticjob/ElasticJobScalingWorker.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWVsYXN0aWNqb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZWxhc3RpY2pvYi9FbGFzdGljSm9iU2NhbGluZ1dvcmtlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...here/scaling/elasticjob/job/ScalingElasticJob.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWVsYXN0aWNqb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZWxhc3RpY2pvYi9qb2IvU2NhbGluZ0VsYXN0aWNKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...phere/scaling/elasticjob/util/ElasticJobUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWVsYXN0aWNqb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZWxhc3RpY2pvYi91dGlsL0VsYXN0aWNKb2JVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/mysql/component/MySQLDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NvbXBvbmVudC9NeVNRTERhdGFDb25zaXN0ZW5jeUNoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/postgresql/wal/LogicalReplication.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC93YWwvTG9naWNhbFJlcGxpY2F0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...xecute/executor/importer/AbstractJDBCImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2ltcG9ydGVyL0Fic3RyYWN0SkRCQ0ltcG9ydGVyLmphdmE=) | `86.17% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [30 more](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=footer). Last update [5687ee8...4aa6816](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #8301: Refactoring DataSource Configuration

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8301:
URL: https://github.com/apache/shardingsphere/pull/8301


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8301: Refactoring DataSource Configuration

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8301:
URL: https://github.com/apache/shardingsphere/pull/8301#issuecomment-732053212


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=h1) Report
   > Merging [#8301](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=desc) (a75d223) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5687ee847b30511b2b8269e29f6a96a051fa5827?el=desc) (5687ee8) will **increase** coverage by `0.00%`.
   > The diff coverage is `74.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8301/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #8301   +/-   ##
   =========================================
     Coverage     74.73%   74.74%           
   + Complexity      600      599    -1     
   =========================================
     Files          1483     1483           
     Lines         23431    23420   -11     
     Branches       4174     4169    -5     
   =========================================
   - Hits          17512    17505    -7     
   + Misses         4768     4766    -2     
   + Partials       1151     1149    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apache/shardingsphere/scaling/ServerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9TZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...apache/shardingsphere/scaling/WorkerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9Xb3JrZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...phere/scaling/core/config/DumperConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvRHVtcGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ere/scaling/core/config/ImporterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvSW1wb3J0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...re/scaling/elasticjob/ElasticJobScalingWorker.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWVsYXN0aWNqb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZWxhc3RpY2pvYi9FbGFzdGljSm9iU2NhbGluZ1dvcmtlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...here/scaling/elasticjob/job/ScalingElasticJob.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWVsYXN0aWNqb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZWxhc3RpY2pvYi9qb2IvU2NhbGluZ0VsYXN0aWNKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...phere/scaling/elasticjob/util/ElasticJobUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWVsYXN0aWNqb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvZWxhc3RpY2pvYi91dGlsL0VsYXN0aWNKb2JVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/mysql/component/MySQLDataConsistencyChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL215c3FsL2NvbXBvbmVudC9NeVNRTERhdGFDb25zaXN0ZW5jeUNoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/postgresql/wal/LogicalReplication.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvcG9zdGdyZXNxbC93YWwvTG9naWNhbFJlcGxpY2F0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...xecute/executor/importer/AbstractJDBCImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRlL2V4ZWN1dG9yL2ltcG9ydGVyL0Fic3RyYWN0SkRCQ0ltcG9ydGVyLmphdmE=) | `86.17% <50.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [30 more](https://codecov.io/gh/apache/shardingsphere/pull/8301/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=footer). Last update [5687ee8...4aa6816](https://codecov.io/gh/apache/shardingsphere/pull/8301?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org