[jira] Updated: (SOLR-1138) Query Elevation Component should gracefully handle empty queries

["Grant Ingersoll (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-1138:
----------------------------------

    Attachment: SOLR-1138.patch

Here's a patch that fixes this.  I plan on committing today.

> Query Elevation Component should gracefully handle empty queries
> ----------------------------------------------------------------
>
>                 Key: SOLR-1138
>                 URL: https://issues.apache.org/jira/browse/SOLR-1138
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-1138.patch
>
>
> From http://www.lucidimagination.com/search/document/3b50cd3506952f7 :
> {quote}
> In the QueryElevComponent (QEC) it currently throws an exception if  
> the input Query is null (line 329).    Additionally, I've seen cases  
> where it's possible that the Query is not null (q is not set, but  
> q.alt is *:*), but the rb.getQueryString() is null, which causes an  
> NPE on line 300 or so.
> I'd like to suggest that if the Query is empty/null, the QEC should  
> just go on it's merry way as if there is nothing to do.  I don't think  
> a lack of query means that the QEC is improperly configured, as the  
> exception message implies:
> 	The QueryElevationComponent needs to be registered 'after' the query  
> component
> We should be making sure the QEC is properly registered during  
> initialization time.
> Thoughts?
> -Grant{quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.