You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/02 06:36:19 UTC

[GitHub] rahul003 commented on a change in pull request #10772: Fix row_sparse_pull with single gpu

rahul003 commented on a change in pull request #10772: Fix row_sparse_pull with single gpu
URL: https://github.com/apache/incubator-mxnet/pull/10772#discussion_r185404027
 
 

 ##########
 File path: tests/python/gpu/test_kvstore_gpu.py
 ##########
 @@ -91,6 +91,21 @@ def check_rsp_pull(kv, count, ctxs, is_same_rowid=False, use_slice=False):
     check_rsp_push_pull('device')
     check_rsp_push_pull('device', is_push_cpu=False)
 
+
+def test_row_sparse_pull_single_device():
 
 Review comment:
   The test is in kvstore gpu section but uses local kvstore and cpu context. It would probably make sense to change the test here to `device` and `gpu`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services