You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2024/05/19 18:22:24 UTC
[PR] Fix usage of ToggleBookmarkAction in split windows scenario [netbeans]
matthiasblaesing opened a new pull request, #7384:
URL: https://github.com/apache/netbeans/pull/7384
It was observed, that the "Goto Bookmark" actions cause the goto action in the correct window (the focused one or the one the toolbar is located in), while the "Toogle Bookmark" action invokes the action for the first editor window.
The implementation of the ToggleBookmarkAction implies that the button should reflect whether or not there s a bookmark on the current line (rendering the button active/pressed when there is a bookmark). It was observered, that this does not work.
So instead of fixing the complex implementation, the implementation for ToggleBookmarkAction was aligned with the "GotoBookmarkAction", inheriting the "find the right text component" behavior from BaseAction.
Closes: #4155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix usage of ToggleBookmarkAction in split windows scenario [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7384:
URL: https://github.com/apache/netbeans/pull/7384#issuecomment-2145678214
Will merge shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix usage of ToggleBookmarkAction in split windows scenario [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #7384:
URL: https://github.com/apache/netbeans/pull/7384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists