You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jkeshavarzi <gi...@git.apache.org> on 2014/08/20 17:04:48 UTC
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
GitHub user jkeshavarzi opened a pull request:
https://github.com/apache/cordova-blackberry/pull/175
Changing WebInspector dialog to a toast
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry/cordova-blackberry inspector-toast
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-blackberry/pull/175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #175
----
commit 945d107cf560e1c39ea676d841c1e527f893e9fe
Author: James Keshavarzi <jk...@blackberry.com>
Date: 2014-08-20T15:03:14Z
Changing WebInspector dialog to a toast
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by jkeshavarzi <gi...@git.apache.org>.
Github user jkeshavarzi commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-52794458
Some valid points here. I wasn't part of the initial discussion where this feature was requested.
Perhaps we should wait until Bryan comes back from vacation and reopen the discussion.
@kwallis thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-52792890
So...
The rules for toasts are that they're supposed to be short, and unimportant.
There's theoretical information in this dialog that you might want (the IP address).
This dialog also functions as a breakpoint, to enable debugging stuff that might run immediately after you dismiss it.
I'm not comfortable w/ this change. If @bryanhiggins wants to do it, fine.
Personally, if we don't want the initial breakpoint -- http://msdn.microsoft.com/en-us/library/windows/hardware/ff550949(v=vs.85).aspx then,
removing the dialog and making it into an Instant preview -- https://developer.blackberry.com/native/documentation/cascades/device_comm/notifications/index.html#pat1391200901973 would seem to be the logical choice...
Unless of course that requires an extra permission, in which case... *sigh*.
Note that as an instant preview (or at least a Hub Notification), I'm able to copy the data somewhere instead of hand typing it. Which would be good...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-54486943
Merged
@jkeshavarzi can you please close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by jkeshavarzi <gi...@git.apache.org>.
Github user jkeshavarzi commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-52791380
@jsoref Can you please review this for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by jkeshavarzi <gi...@git.apache.org>.
Github user jkeshavarzi commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-52933725
@efidler
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by jkeshavarzi <gi...@git.apache.org>.
Github user jkeshavarzi closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by kwallis <gi...@git.apache.org>.
Github user kwallis commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-52932233
Eli also had thoughts on this, but I don't know his GitHub handle
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: Changing WebInspector dialog to a...
Posted by eyezak <gi...@git.apache.org>.
Github user eyezak commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/175#issuecomment-53720784
The "breakpoint" functionality of the dialog is a BlackBerry10 specific behaviour, prohibiting tools from coding once for all platforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---