You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2016/09/20 05:22:47 UTC
logging-log4j2 git commit: Add final to private fields.
Repository: logging-log4j2
Updated Branches:
refs/heads/master ce7e49839 -> e889d2b24
Add final to private fields.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e889d2b2
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e889d2b2
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e889d2b2
Branch: refs/heads/master
Commit: e889d2b24bb46542d20678235c557c89abd4dc89
Parents: ce7e498
Author: Gary Gregory <gg...@apache.org>
Authored: Mon Sep 19 22:22:44 2016 -0700
Committer: Gary Gregory <gg...@apache.org>
Committed: Mon Sep 19 22:22:44 2016 -0700
----------------------------------------------------------------------
.../async/AsyncLoggerAllThreadContextImplementationsTest.java | 4 ++--
.../AsyncLoggerConfigAllThreadContextImplementationsTest.java | 2 +-
.../logging/log4j/core/impl/NestedLoggingFromToStringTest.java | 2 +-
.../apache/logging/log4j/perf/nogc/OpenHashMapContextData.java | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e889d2b2/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
index 38d959f..35edf29 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerAllThreadContextImplementationsTest.java
@@ -47,8 +47,8 @@ import static org.junit.Assert.*;
public class AsyncLoggerAllThreadContextImplementationsTest {
final static int LINE_COUNT = 130;
- private ContextImpl contextImpl;
- private Mode asyncMode;
+ private final ContextImpl contextImpl;
+ private final Mode asyncMode;
@BeforeClass
public static void beforeClass() {
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e889d2b2/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
index 4d09ffb..6ec9640 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggerConfigAllThreadContextImplementationsTest.java
@@ -47,7 +47,7 @@ import static org.junit.Assert.*;
public class AsyncLoggerConfigAllThreadContextImplementationsTest {
final static int LINE_COUNT = 130;
- private ContextImpl contextImpl;
+ private final ContextImpl contextImpl;
@BeforeClass
public static void beforeClass() {
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e889d2b2/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromToStringTest.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromToStringTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromToStringTest.java
index 995232a..8aa57b0 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromToStringTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromToStringTest.java
@@ -58,7 +58,7 @@ public class NestedLoggingFromToStringTest {
static class ParameterizedLoggingThing {
final Logger innerLogger = LogManager.getLogger(ParameterizedLoggingThing.class);
- private int x = 3, y = 4, z = 5;
+ private final int x = 3, y = 4, z = 5;
public int getX() {
innerLogger.debug("getX: values x={} y={} z={}", x, y, z);
return x;
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e889d2b2/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
----------------------------------------------------------------------
diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
index 07b2294..8a3bf17 100644
--- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
+++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/nogc/OpenHashMapContextData.java
@@ -89,7 +89,7 @@ public class OpenHashMapContextData<K, V> implements MutableContextData, ThreadC
/** The acceptable load factor. */
protected final float loadFactor;
- private V defRetValue = null;
+ private final V defRetValue = null;
private boolean immutable;
private transient boolean iterating;