You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Liu Jia (Created) (JIRA)" <ji...@apache.org> on 2011/12/14 17:23:30 UTC
[jira] [Created] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
--------------------------------------------------------------------
Key: HBASE-5026
URL: https://issues.apache.org/jira/browse/HBASE-5026
Project: HBase
Issue Type: Bug
Components: coprocessors
Affects Versions: 0.92.0
Reporter: Liu Jia
Assignee: Liu Jia
Fix For: 0.92.0
The RegionObserver's preScannerClose() and postScannerClose()
methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170098#comment-13170098 ]
Hudson commented on HBASE-5026:
-------------------------------
Integrated in HBase-0.92-security #39 (See [https://builds.apache.org/job/HBase-0.92-security/39/])
HBASE-5026 Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0, 0.94.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169632#comment-13169632 ]
Zhihong Yu commented on HBASE-5026:
-----------------------------------
This is the first time I saw the following for a test build (https://builds.apache.org/job/PreCommit-HBASE-Build/504//testReport/org.apache.hadoop.hbase.client/TestAdmin/testCheckHBaseAvailableClosesConnection/):
{code}
java.lang.InternalError: errno: 24 error: Unable to open directory /proc/self/fd
{code}
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170137#comment-13170137 ]
Hudson commented on HBASE-5026:
-------------------------------
Integrated in HBase-TRUNK-security #32 (See [https://builds.apache.org/job/HBase-TRUNK-security/32/])
HBASE-5026 Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0, 0.94.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169930#comment-13169930 ]
Hudson commented on HBASE-5026:
-------------------------------
Integrated in HBase-TRUNK #2545 (See [https://builds.apache.org/job/HBase-TRUNK/2545/])
HBASE-5026 Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0, 0.94.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169980#comment-13169980 ]
Hudson commented on HBASE-5026:
-------------------------------
Integrated in HBase-0.92 #190 (See [https://builds.apache.org/job/HBase-0.92/190/])
HBASE-5026 Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0, 0.94.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Liu Jia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Jia updated HBASE-5026:
---------------------------
Status: Patch Available (was: Open)
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5026:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0, 0.94.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169573#comment-13169573 ]
Hadoop QA commented on HBASE-5026:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507376/RegionObserverLeaseExpired.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -152 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 75 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/504//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/504//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/504//console
This message is automatically generated.
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Andrew Purtell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169596#comment-13169596 ]
Andrew Purtell commented on HBASE-5026:
---------------------------------------
+1
Any case where the CP framework misses a scanner close is a bug.
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169639#comment-13169639 ]
Zhihong Yu commented on HBASE-5026:
-----------------------------------
TestAdmin doesn't utilize coprocessor - the test failures were unrelated.
Integrated to branch and TRUNK.
Thanks for the patch, Jia.
Thanks for the review Andy.
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0, 0.94.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169490#comment-13169490 ]
jiraposter@reviews.apache.org commented on HBASE-5026:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3197/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired(),the RegionObserver's preScannerClose() and postScannerClose()
methods should cover the scanner leaseExpired() situation.The following code is provided by Ted.
This addresses bug HBASE-5026.
https://issues.apache.org/jira/browse/HBASE-5026
Diffs
-----
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1213130
Diff: https://reviews.apache.org/r/3197/diff
Testing
-------
Test done.
Thanks,
Jia
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5026:
------------------------------
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0, 0.94.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5026) Add coprocessor hook to
HRegionServer.ScannerListener.leaseExpired()
Posted by "Liu Jia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liu Jia updated HBASE-5026:
---------------------------
Attachment: RegionObserverLeaseExpired.patch
> Add coprocessor hook to HRegionServer.ScannerListener.leaseExpired()
> --------------------------------------------------------------------
>
> Key: HBASE-5026
> URL: https://issues.apache.org/jira/browse/HBASE-5026
> Project: HBase
> Issue Type: Bug
> Components: coprocessors
> Affects Versions: 0.92.0
> Reporter: Liu Jia
> Assignee: Liu Jia
> Fix For: 0.92.0
>
> Attachments: RegionObserverLeaseExpired.patch
>
>
> The RegionObserver's preScannerClose() and postScannerClose()
> methods should cover the scanner leaseExpired() situation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira