You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2015/09/28 18:33:18 UTC

[GitHub] incubator-brooklyn pull request: MS SQL blueprint - improve instal...

GitHub user bostko opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/925

    MS SQL blueprint - improve installation script

    pass the exit code from the install command to the install script

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bostko/incubator-brooklyn mssql_blueprint

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/925.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #925
    
----
commit 3671f943d662f7c7331b4734336583037d92ee9f
Author: Valentin Aitken <va...@cloudsoftcorp.com>
Date:   2015-09-28T16:10:22Z

    MS SQL blueprint - improve installation script
    
    pass the exit code from the install command to the install script

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: MS SQL blueprint - improve instal...

Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/925#issuecomment-143988954
  
    Looks like a sensible change. Does the `MssqlBlueprintLiveTest` still work, and still correctly install SQL?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: MS SQL blueprint - improve instal...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/925#issuecomment-145640944
  
    Thanks @bostko (and thanks @nakomis for reviewing). Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: MS SQL blueprint - improve instal...

Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/925#issuecomment-144004179
  
    Yes it works.
    I am testing now other mssql scripts whether they return exit code from the commands.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: MS SQL blueprint - improve instal...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/925


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---