[GitHub] [ignite] Mmuzaf commented on a diff in pull request #10082: IGNITE-17140 Snapshot restore: fixed remote partitions files move

[GitBox <gi...@apache.org>]

Mmuzaf commented on code in PR #10082:
URL: https://github.com/apache/ignite/pull/10082#discussion_r898230518


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java:
##########
@@ -1002,38 +1007,22 @@ private IgniteInternalFuture<Boolean> preload(UUID reqId) {
                                 if (opCtx0.stopChecker.getAsBoolean())
                                     throw new IgniteInterruptedException("Snapshot remote operation request cancelled.");
 
-                                if (t == null) {
-                                    int grpId = CU.cacheId(cacheGroupName(snpFile.getParentFile()));
-                                    int partId = partId(snpFile.getName());
-
-                                    PartitionRestoreFuture partFut = F.find(allParts.get(grpId),
-                                        null,
-                                        new IgnitePredicate<PartitionRestoreFuture>() {
-                                            @Override public boolean apply(PartitionRestoreFuture f) {
-                                                return f.partId == partId;
-                                            }
-                                        });
+                                if (t != null) {
+                                    opCtx0.errHnd.accept(t);
+                                    completeListExceptionally(rmtAwaitParts, t);
 
-                                    assert partFut != null : snpFile.getAbsolutePath();
+                                    return;
+                                }
 
-                                    File tmpCacheDir = formatTmpDirName(grpToDir.get(grpId));
+                                int grpId = tmpDirGroupId(snpFile.getParentFile());

Review Comment:
   Let's also add an assertion that the received partition file have the `formatTmpDirName` location.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org