You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by James McCoy <ja...@debian.org> on 2015/03/08 05:21:53 UTC
[patch] Fix test failures with certain directory names (was:
1.9.0-beta1 up for testing/signing)
On Thu, Mar 05, 2015 at 04:09:11PM -0800, Ben Reser wrote:
> The 1.9.0-beta1 release artifacts are now available for testing/signing.
I was testing this from within a directory named subversion-1.9.0~beta1
and a number of tests failed due to differences in whether the ~ was
URL-escaped. The attached patch fixes the issue for me.
Cheers,
--
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <ja...@debian.org>
Re: [patch] Fix test failures with certain directory names (was:
1.9.0-beta1 up for testing/signing)
Posted by 'James McCoy' <ja...@debian.org>.
On Sun, Mar 08, 2015 at 03:32:35PM +0100, Bert Huijben wrote:
> > -----Original Message-----
> > From: James McCoy [mailto:jamessan@debian.org]
> > Sent: zondag 8 maart 2015 05:22
> > To: dev@subversion.apache.org
> > Subject: [patch] Fix test failures with certain directory names (was: 1.9.0-beta1
> > up for testing/signing)
> >
> > On Thu, Mar 05, 2015 at 04:09:11PM -0800, Ben Reser wrote:
> > > The 1.9.0-beta1 release artifacts are now available for testing/signing.
> >
> > I was testing this from within a directory named subversion-1.9.0~beta1
> > and a number of tests failed due to differences in whether the ~ was
> > URL-escaped. The attached patch fixes the issue for me.
>
> I applied a tweaked version of the patch in r1664997. Can you verify if this fixes the problems for you?
That does fix the problem. Thanks.
--
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <ja...@debian.org>
RE: [patch] Fix test failures with certain directory names (was: 1.9.0-beta1 up for testing/signing)
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: James McCoy [mailto:jamessan@debian.org]
> Sent: zondag 8 maart 2015 05:22
> To: dev@subversion.apache.org
> Subject: [patch] Fix test failures with certain directory names (was: 1.9.0-beta1
> up for testing/signing)
>
> On Thu, Mar 05, 2015 at 04:09:11PM -0800, Ben Reser wrote:
> > The 1.9.0-beta1 release artifacts are now available for testing/signing.
>
> I was testing this from within a directory named subversion-1.9.0~beta1
> and a number of tests failed due to differences in whether the ~ was
> URL-escaped. The attached patch fixes the issue for me.
I applied a tweaked version of the patch in r1664997. Can you verify if this fixes the problems for you?
Your version of the patch somehow showed that we relied on some side effect of the quoting function to generate the urls on Windows. As a result I couldn't run a single python test.
With a few small tweaks I think I fixes those problems.
Thanks for your report + patch,
Bert