You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/16 08:40:39 UTC
[GitHub] [flink] godfreyhe opened a new pull request #14400: [FLINK-20516][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
godfreyhe opened a new pull request #14400:
URL: https://github.com/apache/flink/pull/14400
## What is the purpose of the change
*Separate the implementation of BatchExecCalc and StreamExecCalc*
## Brief change log
- *Introduce StreamPhysicalCalc & StreamPhysicalPythonCalc, and make StreamExecCalc & StreamExecPythonCalc only extended from ExecNode*
- *Introduce BatchPhysicalCalc & BatchPhysicalPythonCalc, and make BatchExecCalc & BatchExecPythonCalc only extended from ExecNode*
## Verifying this change
This change is a refactoring rework covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14400:
URL: https://github.com/apache/flink/pull/14400#discussion_r546597347
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java
##########
@@ -20,6 +20,7 @@
import org.apache.flink.api.dag.Transformation;
import org.apache.flink.table.delegation.Planner;
+import org.apache.flink.table.planner.plan.nodes.exec.common.CommonExecExchange;
Review comment:
In ExecNode, We have removed type parameter `P`, the new method is `Transformation<T> translateToPlan(Planner planner)`. If we support mixed mode in the future, the BatchPlanner and StreamPlanner also need to refactor. We can refactor this after we have a clearer thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107",
"triggerID" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"triggerType" : "PUSH"
}, {
"hash" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11118",
"triggerID" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0cd9c9ceb472eb145b9b03b90d61390447a1ff2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11118)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-749296353
There is an [issue](https://issues.apache.org/jira/browse/FLINK-20679) to tract the failure, I will merge this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745926547
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ac4ca54147b4a66c2310ecfa31c731c295552809 (Wed Dec 16 08:43:40 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac4ca54147b4a66c2310ecfa31c731c295552809 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922)
* d37a896391cd2b590044d3ec1074798cb01bdbed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-748935539
Thanks for the review, I will merge this once the test is success
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107",
"triggerID" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"triggerType" : "PUSH"
}, {
"hash" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
* 26a48041346a7f7565629dfeacab5a3fdcd72f7d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107)
* e0cd9c9ceb472eb145b9b03b90d61390447a1ff2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac4ca54147b4a66c2310ecfa31c731c295552809 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14400:
URL: https://github.com/apache/flink/pull/14400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
* 26a48041346a7f7565629dfeacab5a3fdcd72f7d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14400:
URL: https://github.com/apache/flink/pull/14400#discussion_r546597347
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java
##########
@@ -20,6 +20,7 @@
import org.apache.flink.api.dag.Transformation;
import org.apache.flink.table.delegation.Planner;
+import org.apache.flink.table.planner.plan.nodes.exec.common.CommonExecExchange;
Review comment:
In ExecNode, We have removed type parameter `P`, the new method is `Transformation<T> translateToPlan(Planner planner)`. If we support mixed mode, the BatchPlanner and StreamPlanner also need to refactor. We can refactor this after we have a clearer thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-748624829
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107",
"triggerID" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"triggerType" : "PUSH"
}, {
"hash" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11118",
"triggerID" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26a48041346a7f7565629dfeacab5a3fdcd72f7d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107)
* e0cd9c9ceb472eb145b9b03b90d61390447a1ff2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11118)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14400:
URL: https://github.com/apache/flink/pull/14400#discussion_r546594922
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecCalc.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.common;
+
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.delegation.Planner;
+import org.apache.flink.table.planner.codegen.CalcCodeGenerator;
+import org.apache.flink.table.planner.codegen.CodeGeneratorContext;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.utils.JavaScalaConversionUtil;
+import org.apache.flink.table.runtime.operators.AbstractProcessStreamOperator;
+import org.apache.flink.table.runtime.operators.CodeGenOperatorFactory;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexProgram;
+
+import java.util.Optional;
+
+/**
+ * Base class for exec Calc.
+ */
+public interface CommonExecCalc extends ExecNode<RowData> {
+
+ @SuppressWarnings("unchecked")
+ default Transformation<RowData> translateToPlan(
Review comment:
How about `translateToTransformation` ? because `tanslateToPlanInternal ` is also a method defined in ExecNodeBase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107",
"triggerID" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
* 26a48041346a7f7565629dfeacab5a3fdcd72f7d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac4ca54147b4a66c2310ecfa31c731c295552809 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac4ca54147b4a66c2310ecfa31c731c295552809 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-749296353
There is a [issue](https://issues.apache.org/jira/browse/FLINK-20679) to tract the failure, I will merge this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #14400:
URL: https://github.com/apache/flink/pull/14400#discussion_r546333491
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecCalc.java
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.common;
+
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.delegation.Planner;
+import org.apache.flink.table.planner.codegen.CalcCodeGenerator;
+import org.apache.flink.table.planner.codegen.CodeGeneratorContext;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.utils.JavaScalaConversionUtil;
+import org.apache.flink.table.runtime.operators.AbstractProcessStreamOperator;
+import org.apache.flink.table.runtime.operators.CodeGenOperatorFactory;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.rex.RexProgram;
+
+import java.util.Optional;
+
+/**
+ * Base class for exec Calc.
+ */
+public interface CommonExecCalc extends ExecNode<RowData> {
+
+ @SuppressWarnings("unchecked")
+ default Transformation<RowData> translateToPlan(
Review comment:
I would suggest to use another name, because tanslateToPlan is the base interface of ExecNode. Maybe tanslateToPlanInternal ?
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java
##########
@@ -20,6 +20,7 @@
import org.apache.flink.api.dag.Transformation;
import org.apache.flink.table.delegation.Planner;
+import org.apache.flink.table.planner.plan.nodes.exec.common.CommonExecExchange;
Review comment:
Can we remove the template paramter: P extends Planner, just use Planner instead.
because currently there is no need on special function on StreamPlanner and BatchPlanner, and in the future, I think we may want StreamExecNode and BatchExecNode can be unified and run in mixed mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "748624829",
"triggerType" : "MANUAL"
}, {
"hash" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107",
"triggerID" : "26a48041346a7f7565629dfeacab5a3fdcd72f7d",
"triggerType" : "PUSH"
}, {
"hash" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11118",
"triggerID" : "e0cd9c9ceb472eb145b9b03b90d61390447a1ff2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11078) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
* 26a48041346a7f7565629dfeacab5a3fdcd72f7d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11107)
* e0cd9c9ceb472eb145b9b03b90d61390447a1ff2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11118)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14400: [FLINK-20610][table-planner-blink] Separate the implementation of BatchExecCalc and StreamExecCalc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14400:
URL: https://github.com/apache/flink/pull/14400#issuecomment-745936223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922",
"triggerID" : "ac4ca54147b4a66c2310ecfa31c731c295552809",
"triggerType" : "PUSH"
}, {
"hash" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036",
"triggerID" : "d37a896391cd2b590044d3ec1074798cb01bdbed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac4ca54147b4a66c2310ecfa31c731c295552809 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10922)
* d37a896391cd2b590044d3ec1074798cb01bdbed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org