[GitHub] [accumulo] ctubbsii commented on a change in pull request #2591: Make ZooZap keyword executable

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2591:
URL: https://github.com/apache/accumulo/pull/2591#discussion_r835555652



##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java
##########
@@ -69,7 +82,8 @@ private static void message(String msg, Opts opts) {
     boolean verbose = false;
   }
 
-  public static void main(String[] args) {
+  @Override
+  public void execute(String[] args) throws Exception {
     Opts opts = new Opts();
     opts.parseArgs(ZooZap.class.getName(), args);

Review comment:
       I think this should now probably be:
   
   ```java
       opts.parseArgs(keyword(), args);
   ```

##########
File path: server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java
##########
@@ -69,7 +82,8 @@ private static void message(String msg, Opts opts) {
     boolean verbose = false;
   }
 
-  public static void main(String[] args) {

Review comment:
       The ZooZap main class is mentioned in the draft release notes for 2.1.0, and should be updated to reflect the keyword instead, since the main method is removed.
   
   The assemble/bin/accumulo-cluster script tries to execute this as a main class, and will need to be updated to use the keyword executable, or it will need to have the main method re-added as an alternate entry point.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org