[GitHub] [incubator-superset] john-bodley removed a comment on pull request #10070: fix: use custom int parsing over flask int parsing in sqllab queries endpoint

[GitBox <gi...@apache.org>]

john-bodley removed a comment on pull request #10070:
URL: https://github.com/apache/incubator-superset/pull/10070#issuecomment-645141485


   Actually @ktmud it seems like `float` isn't valid as per [here](https://github.com/pallets/werkzeug/blob/237b35a63631fda0fe80eb51dccdfe8a2f50d304/src/werkzeug/routing.py#L1277) (and the associated regex) it _only_ supports floating point numbers whereas ideally we would want to handle both floats and integers as far as I can tell.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org