You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/11/06 19:27:28 UTC
[kudu-CR](branch-1.17.x) [build] Make uncompress symbols local in exported libkudu client.so
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20665
Change subject: [build] Make uncompress symbols local in exported libkudu_client.so
......................................................................
[build] Make uncompress symbols local in exported libkudu_client.so
in redhat 8.8 and ubuntu 22.04 graviton instances the uncompress and
uncompress2 symbols form libz get to libkudu_client.so. They shoud
be made local too. Adding them to symbol.map
Change-Id: I5033eef9dee6711f302d877cfb81a066b65f0319
Reviewed-on: http://gerrit.cloudera.org:8080/20590
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 5d6dcfd2470fc9e3144e9fe593063c90cd82bef3)
---
M src/kudu/client/symbols.map
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/20665/1
--
To view, visit http://gerrit.cloudera.org:8080/20665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5033eef9dee6711f302d877cfb81a066b65f0319
Gerrit-Change-Number: 20665
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR](branch-1.17.x) [build] Make uncompress symbols local in exported libkudu client.so
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20665 )
Change subject: [build] Make uncompress symbols local in exported libkudu_client.so
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5033eef9dee6711f302d877cfb81a066b65f0319
Gerrit-Change-Number: 20665
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2023 02:35:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [build] Make uncompress symbols local in exported libkudu client.so
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20665 )
Change subject: [build] Make uncompress symbols local in exported libkudu_client.so
......................................................................
[build] Make uncompress symbols local in exported libkudu_client.so
in redhat 8.8 and ubuntu 22.04 graviton instances the uncompress and
uncompress2 symbols form libz get to libkudu_client.so. They shoud
be made local too. Adding them to symbol.map
Change-Id: I5033eef9dee6711f302d877cfb81a066b65f0319
Reviewed-on: http://gerrit.cloudera.org:8080/20590
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 5d6dcfd2470fc9e3144e9fe593063c90cd82bef3)
Reviewed-on: http://gerrit.cloudera.org:8080/20665
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/client/symbols.map
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I5033eef9dee6711f302d877cfb81a066b65f0319
Gerrit-Change-Number: 20665
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>