You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/31 08:29:45 UTC

[GitHub] [incubator-devlake] e2corporation commented on pull request #2898: feat: replace specific vars in connection with an object.

e2corporation commented on PR #2898:
URL: https://github.com/apache/incubator-devlake/pull/2898#issuecomment-1232630246

   @likyh This current Connection Form is a controlled form design of specific Connection Properties. You are destroying nicely designed state variables so you can stuff state in to a Configuration Object meant for reading the Plugin Config? This is not the way, I am going to decline this PR. There is nothing wrong with the state props and setters designed for managing the connection form. If there is a need to consolidate these props into one object at a later time I will do so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org