[GitHub] [airflow] ashb commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler
URL: https://github.com/apache/airflow/pull/6182#discussion_r328311836
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -1077,7 +1080,12 @@ def _enqueue_task_instances_with_queued_state(self, simple_dag_bag,
         :param simple_dag_bag: Should contains all of the task_instances' dags
         :type simple_dag_bag: airflow.utils.dag_processing.SimpleDagBag
         """
+
         TI = models.TaskInstance
+
+        def change_file_path(full_filepath):
+            return re.sub(DAGS_FOLDER, 'DAGS_FOLDER', full_filepath)
 
 Review comment:
   This shouldn't be a regex (as the DAGS_FOLDER is a constant, not a regex) - `full_filepath.replace(DAGS_FOLDER, 'DAGS_FOLDER', 1)` should work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services