You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@mesos.apache.org by "Benjamin Mahler (JIRA)" <ji...@apache.org> on 2016/06/21 21:16:57 UTC

[jira] [Updated] (MESOS-5600) DRF sorter unnecessarily re-sorts due to misuse of "dirty" bit.

     [ https://issues.apache.org/jira/browse/MESOS-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Mahler updated MESOS-5600:
-----------------------------------
    Summary: DRF sorter unnecessarily re-sorts due to misuse of "dirty" bit.  (was: "dirty" was never set back as false in sorter)

> DRF sorter unnecessarily re-sorts due to misuse of "dirty" bit.
> ---------------------------------------------------------------
>
>                 Key: MESOS-5600
>                 URL: https://issues.apache.org/jira/browse/MESOS-5600
>             Project: Mesos
>          Issue Type: Bug
>          Components: allocation
>            Reporter: Guangya Liu
>            Assignee: Guangya Liu
>             Fix For: 1.0.0
>
>
> dirty was set as true when the total resource was updated in the cluster, but it was never set back as false. The dirty should be set back as false in DRFSorter::sort https://github.com/apache/mesos/blob/master/src/master/allocator/sorter/drf/sorter.cpp#L320-L334
> The reason that we cannot detect this is because once an agent was added to cluster, the dirty will be set as true and the sorter will always call sort() to calculate share for each framework, this will impact the performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)