You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/03 18:50:53 UTC
[GitHub] [helix] alirezazamani opened a new pull request #991: Stabilize TestWorkflowTimeout and TestTaskRebalancer
alirezazamani opened a new pull request #991:
URL: https://github.com/apache/helix/pull/991
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR title:
Fixes #989
Fixes #988
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
In this commit, two tests have been stabilized.
These tests are TestWorkflowTimeout and TestTaskRebalancer.
These tests are unstable because they are relying on Thread.Sleep()
### Tests
- [x] The following is the result of the "mvn test" command on the appropriate module:
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestJobQueueCleanUp.testJobQueueAutoCleanUp » ThreadTimeout Method org.testng....
[ERROR] TestWorkflowTermination.testWorkflowJobFail:223 » Helix Workflow "testWorkflow...
[ERROR] TestWorkflowTermination.testWorkflowRunningTimeout:131->verifyWorkflowCleanup:257 expected:<true> but was:<false>
[INFO]
[ERROR] Tests run: 1144, Failures: 3, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:24 h
[INFO] Finished at: 2020-05-01T13:15:17-07:00
[INFO] ------------------------------------------------------------------------
The failed tests have passed when I ran them individually.
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani commented on pull request #991: Stabilize TestWorkflowTimeout and TestTaskRebalancer
Posted by GitBox <gi...@apache.org>.
alirezazamani commented on pull request #991:
URL: https://github.com/apache/helix/pull/991#issuecomment-623604938
This PR is ready to be merged, approved by @dasahcc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org