You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/09/20 05:24:41 UTC

[GitHub] [avro] martin-g commented on a change in pull request #1342: AVRO-3212: fix specification to allow doc in fixed types

martin-g commented on a change in pull request #1342:
URL: https://github.com/apache/avro/pull/1342#discussion_r711883732



##########
File path: doc/src/content/xdocs/spec.xml
##########
@@ -254,14 +254,16 @@
         <section>
           <title>Fixed</title>
           <p>Fixed uses the type name <code>"fixed"</code> and supports
-          two attributes:</p>
+          the following attributes:</p>
 	  <ul>
 	    <li><code>name</code>: a string naming this fixed (required).</li>
 	    <li><em>namespace</em>, a string that qualifies the name;</li>

Review comment:
       A few questions not directly related to this PR: 
   1) Should we add `(optional)` for namespace too ?
   2) Why it uses `<em>` instead of `<code>` like all other attributes ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org