You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/28 11:25:53 UTC
[GitHub] [superset] codecov[bot] commented on pull request #21143: fix(plugin-chart-handlebars): Fixed issue with Helpers
codecov[bot] commented on PR #21143:
URL: https://github.com/apache/superset/pull/21143#issuecomment-1229436978
# [Codecov](https://codecov.io/gh/apache/superset/pull/21143?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21143](https://codecov.io/gh/apache/superset/pull/21143?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d77a90f) into [master](https://codecov.io/gh/apache/superset/commit/d408393ba9bb6c81c661248521be93dd70c9e19b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d408393) will **decrease** coverage by `0.00%`.
> The diff coverage is `65.71%`.
```diff
@@ Coverage Diff @@
## master #21143 +/- ##
==========================================
- Coverage 66.40% 66.40% -0.01%
==========================================
Files 1783 1788 +5
Lines 68087 68191 +104
Branches 7261 7298 +37
==========================================
+ Hits 45215 45284 +69
- Misses 21007 21034 +27
- Partials 1865 1873 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.33% <65.71%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ars/src/components/Handlebars/HandlebarsViewer.tsx](https://codecov.io/gh/apache/superset/pull/21143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvY29tcG9uZW50cy9IYW5kbGViYXJzL0hhbmRsZWJhcnNWaWV3ZXIudHN4) | `0.00% <0.00%> (ø)` | |
| [...lugins/plugin-chart-handlebars/src/helpers/html.ts](https://codecov.io/gh/apache/superset/pull/21143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvaGVscGVycy9odG1sLnRz) | `33.33% <33.33%> (ø)` | |
| [...ugins/plugin-chart-handlebars/src/helpers/utils.ts](https://codecov.io/gh/apache/superset/pull/21143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvaGVscGVycy91dGlscy50cw==) | `42.85% <42.85%> (ø)` | |
| [...lugin-chart-handlebars/src/helpers/conditionals.ts](https://codecov.io/gh/apache/superset/pull/21143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvaGVscGVycy9jb25kaXRpb25hbHMudHM=) | `59.52% <59.52%> (ø)` | |
| [...ins/plugin-chart-handlebars/src/helpers/strings.ts](https://codecov.io/gh/apache/superset/pull/21143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvaGVscGVycy9zdHJpbmdzLnRz) | `87.87% <87.87%> (ø)` | |
| [...lugins/plugin-chart-handlebars/src/helpers/math.ts](https://codecov.io/gh/apache/superset/pull/21143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvaGVscGVycy9tYXRoLnRz) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org